Adds SEPA Debit PaymentMethod #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csabol-stripe
commented
Oct 10, 2019
|
|
||
| NS_ASSUME_NONNULL_BEGIN | ||
|
|
||
| @interface PaymentExampleViewController : UIViewController <STPAuthenticationContext> |
There was a problem hiding this comment.
so we can stop just copy-pasting as we add view controllers. Should definitely modernize this code more though
csabol-stripe
commented
Oct 10, 2019
| @@ -105,6 +110,7 @@ - (void)confirmPayment:(STPPaymentIntentParams *)paymentParams | |||
| params.useStripeSDK = @YES; | |||
| } | |||
| [self.apiClient confirmPaymentIntentWithParams:params | |||
| expand:@[@"payment_method"] | |||
There was a problem hiding this comment.
filed a followup for a general solution for this
csabol-stripe
commented
Oct 10, 2019
| @@ -12,6 +12,12 @@ | |||
| #import "STPPaymentMethodParams.h" | |||
| #import "STPPaymentResult.h" | |||
|
|
|||
| @interface STPPaymentIntentParams () | |||
|
|
|||
| @property (nonatomic, nullable, readonly) NSDictionary *mandateData; | |||
There was a problem hiding this comment.
followup to expose this publically
yuki-stripe
approved these changes
Oct 15, 2019
yuki-stripe
approved these changes
Oct 16, 2019
ccen-stripe
pushed a commit
that referenced
this pull request
Sep 19, 2022
* Add UPI prototype * Move UPI support to playground * remove prints * Update playground for Indian merchants * Update PaymentSheetTestPlayground.swift * Add UPI snapshot * Update PaymentSheetSnapshotTests.swift * Use CompatibleColor * respect appearance api in polling vc * Mark polling VC as internal * clean up * Move VPA validation to own file * update todos * Update STPIntentAction.swift * Handle todo * Localize countdown timer * Remove post_confirm_handling_pi_status_specs from form spec * Remove upi next action, update intent directly * Revert "Remove post_confirm_handling_pi_status_specs from form spec" This reverts commit 1989a15ba322c1e426595d49b1ecc7b49577f517. * add back india to playground * Remove UPI from luxe spec * Add UPI automated UI tests * Clean up some white space * Add STPVPANumberValidatorTest * PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds bindings for SEPA Debit on PaymentMethod and adds examples for SEPA Debit and iDEAL.
Motivation
New PaymentMethods!
Testing
Tested w/ "Custom Integration" sample app