Store last selected payment method #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csabol-stripe
approved these changes
Nov 25, 2019
|
Thank you for the fix and merge. Could you tell when this will be released? |
|
Hi @yuki-stripe |
|
@yuki-stripe Great, thank you for the quick response! |
yuki-stripe
pushed a commit
that referenced
this pull request
Oct 4, 2022
* Start on error state * more progress on error state * dispatch force poll after 3 seconds * Localize strings * Remove print statements * Add spacer view for error view * use helper function * Little bit of clean up * Change to 20 seconds suggested by apac team * Update copy * Highlight countdown time * Update fonts * Some clean up * Go back to 5 seconds * Remove force unwrwap * Minor refactor * fix comment * clean up * Avoid retain cycle * finish UI tweaking! * Fix asset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
STPPaymentContextandSTPPaymentOptionsViewControllerpre-select the last selected payment method via a{customer_id: last_selected_payment_method_id}store in NSUserDefaults.Motivation
https://jira.corp.stripe.com/browse/IOS-1365
Testing
Added a UI test that covers reading, writing a PM id, writing nil, and multiple customers.