Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use STPAPIClient.shared by default #1469

Merged
merged 13 commits into from
Jan 22, 2020
Merged

Use STPAPIClient.shared by default #1469

merged 13 commits into from
Jan 22, 2020

Commits on Jan 2, 2020

  1. Fix typo in STPCustomerContext

    @yuki-stripe
    yuki-stripe committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    0620281 View commit details
    Browse the repository at this point in the history

  2. Make STPCustomerContext use STPAPIClient.shared instead of initing a … 

    …new one. This means its api client has the same configuration as the shared one. This gets us closer to "By default, the Stripe SDK uses the STPAPIClient.shared to make API calls."
    @yuki-stripe
    yuki-stripe committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    5f33a47 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2020

  1. Refactor to pass addt'l, overwriting authorization header from APICli… 

    …ent to APIRequest
    @yuki-stripe
    yuki-stripe committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    cf8da80 View commit details
    Browse the repository at this point in the history

  2. Update tests

    @yuki-stripe
    yuki-stripe committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    af876b1 View commit details
    Browse the repository at this point in the history

  3. Refactor PinManagementService, PushProvisioningContext to use APIClie… 

    …nt.sharerd insted of APIClient.clientWithEphemeralKey
    @yuki-stripe
    yuki-stripe committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    af707ae View commit details
    Browse the repository at this point in the history

  4. Fix STPPushProvisioningDetailsFunctionalTest

    @yuki-stripe
    yuki-stripe committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    9401876 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2020

  1. Remove unused apiClient from STPPaymentOptionsViewController

    @yuki-stripe
    yuki-stripe committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    a5f9a24 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2020

  1. Switch APIClient(withConfig:) to APIClient.shared in AddCardVC, BankS… 

    …electionVC
    @yuki-stripe
    yuki-stripe committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    fbb0842 View commit details
    Browse the repository at this point in the history

  2. Switch APIClient(publishableKey:) to APIClient.shared in PaymentContext

    @yuki-stripe
    yuki-stripe committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    4afca06 View commit details
    Browse the repository at this point in the history

  3. Make api client properties public and document that they default to [… 

    …STPAPIClient shared], except for CustomerContext, which requires more refactoring since it uses APIClient class methods.
    @yuki-stripe
    yuki-stripe committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    ce8739d View commit details
    Browse the repository at this point in the history

  4. Refactor Customer APIs to be instance methods, expose apiClient prope… 

    …rty on CustomerContext
    @yuki-stripe
    yuki-stripe committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    8d2f86b View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2020

  1. Add apiClient to PaymentOptionsVC, PaymentOptionsInternalVC. Even tho… 

    …ugh they don't make network requests themselves, they initialize others that do.

Here's a graph:
PaymentContext
  - PaymentOptionsVC
    - PaymentOptionsInternalVC
      - AddCardVC
      - BankSelectionVC
    - AddCardVC

APIClient configuration needs to flow from every node to leaf.
    @yuki-stripe
    yuki-stripe committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    4935914 View commit details
    Browse the repository at this point in the history

  2. Add nullability to STPAPIRequest.h

    @yuki-stripe
    yuki-stripe committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    ae32e57 View commit details
    Browse the repository at this point in the history