-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ApplePayContext handles shipping #1561
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,8 @@ | |
#import "STPAPIClient+ApplePay.h" | ||
#import "STPPaymentMethod.h" | ||
#import "STPPaymentIntentParams.h" | ||
#import "STPPaymentIntentShippingDetailsParams.h" | ||
#import "STPPaymentIntentShippingDetailsAddressParams.h" | ||
#import "STPPaymentIntent+Private.h" | ||
#import "STPPaymentHandler.h" | ||
#import "NSError+Stripe.h" | ||
|
@@ -124,6 +126,28 @@ - (void)_end { | |
self.viewController = nil; | ||
self.delegate = nil; | ||
} | ||
|
||
- (nullable STPPaymentIntentShippingDetailsParams *)_shippingDetailsFromPKPayment:(PKPayment *)payment { | ||
CNPostalAddress *address = payment.shippingContact.postalAddress; | ||
NSPersonNameComponents *name = payment.shippingContact.name; | ||
if (address.street == nil || name == nil) { | ||
// The shipping address street and name are required parameters for a valid STPPaymentIntentShippingDetailsParams | ||
return nil; | ||
} | ||
|
||
STPPaymentIntentShippingDetailsAddressParams *addressParams = [[STPPaymentIntentShippingDetailsAddressParams alloc] initWithLine1:payment.shippingContact.postalAddress.street]; | ||
addressParams.city = address.city; | ||
addressParams.state = address.state; | ||
addressParams.country = address.ISOCountryCode; | ||
addressParams.postalCode = address.postalCode; | ||
|
||
NSPersonNameComponentsFormatter *formatter = [NSPersonNameComponentsFormatter new]; | ||
formatter.style = NSPersonNameComponentsFormatterStyleLong; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This produces a name like "Dr. Jonathan Maple Appleseed Esq." vs. |
||
STPPaymentIntentShippingDetailsParams *shippingParams = [[STPPaymentIntentShippingDetailsParams alloc] initWithAddress:addressParams name:[formatter stringFromPersonNameComponents:name]]; | ||
shippingParams.phone = payment.shippingContact.phoneNumber.stringValue; | ||
|
||
return shippingParams; | ||
} | ||
|
||
#pragma mark - PKPaymentAuthorizationViewControllerDelegate | ||
|
||
|
@@ -258,7 +282,7 @@ - (void)_completePaymentWithPayment:(PKPayment *)payment completion:(nonnull voi | |
} | ||
|
||
// 2. Fetch PaymentIntent client secret from delegate | ||
[self.delegate applePayContext:self didCreatePaymentMethod:paymentMethod completion:^(NSString * _Nullable paymentIntentClientSecret, NSError * _Nullable paymentIntentCreationError) { | ||
[self.delegate applePayContext:self didCreatePaymentMethod:paymentMethod paymentInformation:payment completion:^(NSString * _Nullable paymentIntentClientSecret, NSError * _Nullable paymentIntentCreationError) { | ||
if (paymentIntentCreationError || !self.viewController) { | ||
handleFinalState(STPPaymentStateError, paymentIntentCreationError); | ||
return; | ||
|
@@ -275,6 +299,7 @@ - (void)_completePaymentWithPayment:(PKPayment *)payment completion:(nonnull voi | |
STPPaymentIntentParams *paymentIntentParams = [[STPPaymentIntentParams alloc] initWithClientSecret:paymentIntentClientSecret]; | ||
paymentIntentParams.paymentMethodId = paymentMethod.stripeId; | ||
paymentIntentParams.useStripeSDK = @(YES); | ||
paymentIntentParams.shipping = [self _shippingDetailsFromPKPayment:payment]; | ||
|
||
self.paymentState = STPPaymentStatePending; | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would appreciate scrutiny on this API change!