BOUNCER-1436: Fix ML model loading from wrong bundle #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaimepark-stripe
force-pushed
the
jaimepark/fix_async_load
branch
from
995bde4
to
d3a6776
Compare
sgrant-stripe
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
UxModel was loading from the app-level bundle, not the SDK bundle.
Motivation
https://jira.corp.stripe.com/browse/BOUNCER-1436
#2078
Testing
Created an example app outside of the repo and was able to reproduce the error described in this issue post. The changes fixed this error.
Changelog