Link v3: Assets and component views #4114

davidme-stripe · 2024-10-08T23:55:55Z

Summary

Bring back a grab bag of assets, colors, and component views for Link. These are all self-contained and don't change the current functionality, but will be used by the ViewControllers in later PRs.

The black and white Link logo in the snapshot tests is a known issue — we'll have updated logo assets before launch.

This code was all reviewed previously, but we should give it another look as we merge it back in.

Motivation

Link v2

Testing

Resurrected some snapshot tests

Changelog

None

emerge-tools · 2024-10-09T00:05:06Z

⚠️ 1 new unused protocol, 3 builds increased size, 3 builds had no size change

Name	Version	Download	Change	Install	Change	Approval
StripeSize com.stripe.StripeSize	1.0 (1)	2.4 MB	⬆️ 441 B (0.02%)	7.8 MB	⬆️ 320 B	N/A
StripeApplePaySize com.stripe.StripeApplePaySize	1.0 (1)	437.5 kB	-	1.5 MB	-	N/A
StripeFinancialConnectionsSize com.stripe.StripeFinancialConnectionsSize	1.0 (1)	1.3 MB	⬆️ 4 B	4.3 MB	-	N/A
StripePaymentsSize com.stripe.StripePaymentsSize	1.0 (1)	1.2 MB	-	4.1 MB	-	N/A
StripePaymentsUISize com.stripe.StripePaymentsUISize	1.0 (1)	1.9 MB	⬆️ 701 B (0.04%)	6.3 MB	⬆️ 320 B	N/A
StripePaymentSheetSize com.stripe.StripePaymentSheetSize	1.0 (1)	3.5 MB	⬆️ 10.7 kB (0.31%)	10.4 MB	⬆️ 30.5 kB (0.3%)	N/A

StripeSize 1.0 (1)
com.stripe.StripeSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 320 B
Total download size change: ⬆️ 441 B (0.02%)

Largest size changes

Item	Install Size Change
📝 StripePaymentsUI.CardBrandView.init(showCVC,centerHorizontally)	⬆️ 1.8 kB
🗑 StripePaymentsUI.CardBrandView.init(showCVC)	⬇️ -1.7 kB
Other	⬆️ 228 B

View Treemap

StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize

No changes to report

StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize

No changes to report

StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize

No changes to report

StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 320 B
Total download size change: ⬆️ 701 B (0.04%)

Largest size changes

Item	Install Size Change
📝 StripePaymentsUI.CardBrandView.init(showCVC,centerHorizontally)	⬆️ 1.8 kB
🗑 StripePaymentsUI.CardBrandView.init(showCVC)	⬇️ -1.7 kB
Other	⬆️ 228 B

View Treemap

StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 30.5 kB (0.3%)
Total download size change: ⬆️ 10.7 kB (0.31%)

Largest size changes

Item	Install Size Change
Packed Asset	⬆️ 0 B
Other	⬆️ 3.3 kB
📝 StripePaymentSheet.LinkNavigationBar.LinkNavigationBar	⬆️ 3.0 kB
📝 StripePaymentsUI.CardBrandView.init(showCVC,centerHorizontally)	⬆️ 1.8 kB
🗑 StripePaymentsUI.CardBrandView.init(showCVC)	⬇️ -1.7 kB

View Treemap

🛸 Powered by Emerge Tools

github-actions · 2024-10-09T00:10:59Z

🚨 New dead code detected in this PR:

LinkBadgeView.swift:15 warning: Class 'LinkBadgeView' is unused
LinkBadgeView.swift:104 warning: Extension 'BadgeType' is unused
LinkNavigationBar.swift:18 warning: Class 'LinkNavigationBar' is unused
LinkNoticeView.swift:17 warning: Class 'LinkNoticeView' is unused
LinkNoticeView.swift:90 warning: Extension 'NoticeType' is unused
LinkToast.swift:11 warning: Imported module 'StripeCore' is unused
LinkToast.swift:17 warning: Class 'LinkToast' is unused
LinkToast.swift:96 warning: Extension 'LinkToast' is unused
LinkToast.swift:171 warning: Extension 'ToastType' is unused
Button+Link.swift:31 warning: Function 'linkSecondary()' is unused
Button+Link.swift:42 warning: Function 'linkPlain()' is unused
Button+Link.swift:52 warning: Function 'linkBordered()' is unused
ConfirmButton+Link.swift:13 warning: Function 'makeLinkButton(callToAction:compact:didTap:)' is unused
UIColor+Link.swift:70 warning: Property 'linkControlHighlight' is unused
UIColor+Link.swift:78 warning: Property 'linkControlLightPlaceholder' is unused
UIColor+Link.swift:84 warning: Property 'linkToastBackground' is unused
UIColor+Link.swift:95 warning: Property 'linkSecondaryButtonForeground' is unused
UIColor+Link.swift:101 warning: Property 'linkSecondaryButtonBackground' is unused
UIColor+Link.swift:107 warning: Property 'linkNeutralBackground' is unused
UIColor+Link.swift:119 warning: Property 'linkDangerBackground' is unused
LinkInstantDebitMandateView.swift:28 warning: Struct 'Constants' is unused
LinkInstantDebitMandateView.swift:39 warning: Property 'textView' is unused
LinkInstantDebitMandateView.swift:59 warning: Initializer 'init(delegate:)' is unused
LinkInstantDebitMandateView.swift:69 warning: Function 'formattedLegalText()' is unused
LinkKeyboardAvoidingScrollView.swift:15 warning: Class 'LinkKeyboardAvoidingScrollView' is unused
LinkKeyboardAvoidingScrollView.swift:57 warning: Extension 'LinkKeyboardAvoidingScrollView' is unused

Please remove the dead code before merging.

If this is intentional, you can bypass this check by adding the label skip dead code check to this PR.

ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with master.

github-actions · 2024-10-09T00:13:10Z

⚠️ Public API changes detected:

StripePaymentSheet

- public var disabledBackgroundColor: UIKit.UIColor?
- public var disabledTextColor: UIKit.UIColor?
- public init(mode: StripePaymentSheet.PaymentSheet.IntentConfiguration.Mode, paymentMethodTypes: [Swift.String]? = nil, onBehalfOf: Swift.String? = nil, paymentMethodConfigurationId: Swift.String? = nil, confirmHandler: @escaping StripePaymentSheet.PaymentSheet.IntentConfiguration.ConfirmHandler, requireCVCRecollection: Swift.Bool = false)
+ public init(mode: StripePaymentSheet.PaymentSheet.IntentConfiguration.Mode, paymentMethodTypes: [Swift.String]? = nil, onBehalfOf: Swift.String? = nil, paymentMethodConfigurationId: Swift.String? = nil, confirmHandler: @escaping StripePaymentSheet.PaymentSheet.IntentConfiguration.ConfirmHandler)
- public var requireCVCRecollection: Swift.Bool

If you are adding a new public API consider the following:

Do these APIs need to be public or can they be protected with @_spi(STP)?
If these APIs need to be public, assess whether they require an API review.

If you are modifying or removing a public API:

Does this require a breaking version change?
Do these changes require API review?

If you confirm these APIs need to be added/updated and have undergone necessary review, add the label modifies public API to this PR to acknowledge and bypass this check.

ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with master.

…utton

wooj-stripe · 2024-10-23T20:02:17Z

StripePaymentSheet/StripePaymentSheet/Resources/Localizations/en.lproj/Localizable.strings

 "By continuing, you agree to authorize payments pursuant to <terms>these terms</terms>." = "By continuing, you agree to authorize payments pursuant to <terms>these terms</terms>.";

+/* Mandate text displayed when paying via Link instant debit. */
+"By continuing, you agree to authorize payments pursuant to these <terms>terms</terms>." = "By continuing, you agree to authorize payments pursuant to these <terms>terms</terms>.";
+


probably outside the scope of this PR, but for ACH, it's:

<terms>these terms</terms>.

and for this one it is:

these <terms>terms</terms>.

...ymentSheet/Resources/StripePaymentSheet.xcassets/Link/icon_link_error.imageset/Contents.json

...eet/StripePaymentSheet/Source/Internal/Link/Components/NavigationBar/LinkNavigationBar.swift

StripePaymentSheet/StripePaymentSheet/Source/Internal/Link/Components/Toast/LinkToast.swift

wooj-stripe · 2024-10-23T20:09:03Z

StripePaymentSheet/StripePaymentSheet/Source/Internal/Link/Components/Toast/LinkToast.swift

+
+    /// Hides toast.
+    ///
+    /// You normally don't need to call this, as the toast will hide on its own after an specific duration.


This comment is vague-- it explains that we don't normally need to call this, but doesn't describe when we should be calling it.

I think it's for if you want to hide it manually. Like maybe you have a "success" toast, then an error immediately occurs and you want to cancel the first toast?

wooj-stripe · 2024-10-23T20:11:01Z

...PaymentSheet/StripePaymentSheet/Source/Internal/Link/Views/LinkInstantDebitMandateView.swift

+        let formattedString = NSMutableAttributedString()
+
+        STPStringUtils.parseRanges(from: string, withTags: Set<String>(links.keys)) { string, matches in


We should be able to leverage:
STPStringUtils.applyLinksToString

At the very least add a todo, if you feel it is out of scope for this PR

Good call, this code predates that

…utton

davidme-stripe added 2 commits October 8, 2024 16:23

Some Link GIT_VALID_PII_OVERRIDE

3f81a9a

Update tests

4f2fea1

Fix lint

c894424

Fix accidentally added files

47756c0

davidme-stripe added the skip dead code check label Oct 9, 2024

davidme-stripe added 6 commits October 8, 2024 18:13

Fix accidentally added files

34552dc

Fix accidentally added files

51e80f4

Merge remote-tracking branch 'origin/master' into relink/assets-and-b…

75492de

…utton

Fix visionOS build

d92e0c5

Fix visionOS build

3eeced0

Fix visionOS build

ff7b4f2

davidme-stripe marked this pull request as ready for review October 10, 2024 00:28

davidme-stripe requested review from a team as code owners October 10, 2024 00:28

davidme-stripe changed the title ~~Link v2: Assets and component views~~ Link v3: Assets and component views Oct 10, 2024

davidme-stripe requested a review from wooj-stripe October 23, 2024 19:30

wooj-stripe reviewed Oct 23, 2024

View reviewed changes

davidme-stripe added 5 commits October 24, 2024 16:30

Feedback GIT_VALID_PII_OVERRIDE

28961ff

Merge remote-tracking branch 'origin/master' into relink/assets-and-b…

20942b2

…utton

Feedback GIT_VALID_PII_OVERRIDE

4cf5ba7

Fix strings

0c940cb

Fix strings

884fbef

davidme-stripe requested a review from wooj-stripe October 25, 2024 16:22

wooj-stripe approved these changes Oct 25, 2024

View reviewed changes

davidme-stripe merged commit 5faf38f into master Oct 25, 2024
6 checks passed

davidme-stripe deleted the relink/assets-and-button branch October 25, 2024 17:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Link v3: Assets and component views #4114

Link v3: Assets and component views #4114

davidme-stripe commented Oct 8, 2024 •

edited

Loading

emerge-tools bot commented Oct 9, 2024 •

edited

Loading

github-actions bot commented Oct 9, 2024 •

edited

Loading

github-actions bot commented Oct 9, 2024 •

edited

Loading

wooj-stripe Oct 23, 2024

wooj-stripe Oct 23, 2024

davidme-stripe Oct 24, 2024

wooj-stripe Oct 23, 2024

davidme-stripe Oct 24, 2024 •

edited

Loading

		let formattedString = NSMutableAttributedString()

		STPStringUtils.parseRanges(from: string, withTags: Set<String>(links.keys)) { string, matches in

Link v3: Assets and component views #4114

Link v3: Assets and component views #4114

Conversation

davidme-stripe commented Oct 8, 2024 • edited Loading

Summary

Motivation

Testing

Changelog

emerge-tools bot commented Oct 9, 2024 • edited Loading

⚠️ 1 new unused protocol, 3 builds increased size, 3 builds had no size change

StripeSize 1.0 (1)com.stripe.StripeSize

StripeApplePaySize 1.0 (1)com.stripe.StripeApplePaySize

StripeFinancialConnectionsSize 1.0 (1)com.stripe.StripeFinancialConnectionsSize

StripePaymentsSize 1.0 (1)com.stripe.StripePaymentsSize

StripePaymentsUISize 1.0 (1)com.stripe.StripePaymentsUISize

StripePaymentSheetSize 1.0 (1)com.stripe.StripePaymentSheetSize

github-actions bot commented Oct 9, 2024 • edited Loading

github-actions bot commented Oct 9, 2024 • edited Loading

StripePaymentSheet

wooj-stripe Oct 23, 2024

Choose a reason for hiding this comment

wooj-stripe Oct 23, 2024

Choose a reason for hiding this comment

davidme-stripe Oct 24, 2024

Choose a reason for hiding this comment

wooj-stripe Oct 23, 2024

Choose a reason for hiding this comment

davidme-stripe Oct 24, 2024 • edited Loading

Choose a reason for hiding this comment

davidme-stripe commented Oct 8, 2024 •

edited

Loading

emerge-tools bot commented Oct 9, 2024 •

edited

Loading

StripeSize 1.0 (1)
com.stripe.StripeSize

StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize

StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize

StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize

StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize

StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize

github-actions bot commented Oct 9, 2024 •

edited

Loading

github-actions bot commented Oct 9, 2024 •

edited

Loading

davidme-stripe Oct 24, 2024 •

edited

Loading