Implement embedded update (part 1)
#4141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-stripe
force-pushed
the
yuki/implement-update
branch
from
b01debe
to
a7caaec
Compare
yuki-stripe
force-pushed
the
yuki/implement-update
branch
from
9741ec8
to
605614a
Compare
wooj-stripe
reviewed
Oct 16, 2024
StripePaymentSheet/StripePaymentSheetTests/PaymentSheet/EmbeddedPaymentElementTest.swift
Show resolved
Hide resolved
StripePaymentSheet/StripePaymentSheetTests/PaymentSheet/EmbeddedPaymentElementTest.swift
Outdated
Show resolved
Hide resolved
wooj-stripe
approved these changes
Oct 16, 2024
wooj-stripe
pushed a commit
that referenced
this pull request
Oct 17, 2024
## Summary Implements `update` w/ cancel functionality. Still to come: 1. Make `view` a view that _contains_ embedded view so we can swap to the updated embedded view with an animation. 1. Restore previous customer input + E2E tests (e.g. load PI -> fill out card form -> update to SI -> expect form to be preserved but w/o checkbox) 1. Make `confirm` handle in-flight and failed `update` calls. 1. (Bonus) Cancel network calls etc. from previous `update` to reduce battery/network usage. Can apply this to FC.update as well. ## Motivation https://jira.corp.stripe.com/browse/MOBILESDK-2524 ## Testing See tests. ## Changelog Not user facing.
yuki-stripe
added a commit
that referenced
this pull request
Oct 21, 2024
## Summary Previous PR: #4141 Makes EmbeddedPaymentElement view a view that contains embedded view so we can swap to the updated embedded view with an animation. https://github.com/user-attachments/assets/533e0fb1-c848-4fea-9793-30347bbd90f1 Still to come: - Restore previous customer input + E2E tests (e.g. load PI -> fill out card form -> update to SI -> expect form to be preserved but w/o checkbox) - Make confirm handle in-flight and failed update calls. - (Bonus) Cancel network calls etc. from previous update to reduce battery/network usage. Can apply this to FC.update as well. ## Motivation https://jira.corp.stripe.com/browse/MOBILESDK-2583 ## Testing See snapshot test. ## Changelog Not user facing --------- Co-authored-by: Nick Porter <88012362+porter-stripe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements
updatew/ cancel functionality.Still to come:
viewa view that contains embedded view so we can swap to the updated embedded view with an animation.confirmhandle in-flight and failedupdatecalls.updateto reduce battery/network usage. Can apply this to FC.update as well.Motivation
https://jira.corp.stripe.com/browse/MOBILESDK-2524
Testing
See tests.
Changelog
Not user facing.