Fix synchronous download manager #4186
Open
+75
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-stripe
requested review from
davidme-stripe,
porter-stripe and
wooj-stripe
davidme-stripe
previously approved these changes
Oct 25, 2024
|
🚨 New dead code detected in this PR: DownloadManager.swift:108 warning: Function 'resetCache()' is unusedPlease remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
mats-stripe
previously approved these changes
Oct 25, 2024
Agreed @mats-stripe! Some discussion here: https://stripe.slack.com/archives/CFA2HJ99A/p1729811584450199?thread_ts=1729805357.152749&cid=CFA2HJ99A |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deleted the synchronous path of code in DownloadManager; this is unsafe (as the comment indicates!) and can deadlock.
The purpose of the synchronous code was, I believe, to make the method return the cached image by synchronously making a network request that would then access the URLSession cache. The better way to do this is to maintain an in-memory cache, implemented in this PR.
I tried to make a minimal change here to fix the deadlock; broader refactor effort is needed and ticketed here: https://jira.corp.stripe.com/browse/MOBILESDK-2604
Testing
See tests
Changelog
See changelog