Remove custom back button in VCs #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only use system back button or Cancel buttons everywhere.
|
👍 |
bg-stripe
reviewed
Sep 7, 2017
|
Yeah maybe? I don't think it's that big a deal tbh and adding extra text to the end will just lead to the back button text being truncated anyway. |
|
There some other adjustments I would make to this page, anyway, some other time:
|
Remove "Back" string from all translations. Fix Xcode project to correctly interpret the simplified Chinese strings file as UTF-8 Remove unused methods.
davidme-stripe
pushed a commit
that referenced
this pull request
Feb 18, 2022
Fixes SwiftUI crash from double presentation (custom flow)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only use system back button or Cancel buttons everywhere.
Our fake Back button we had been using doesn't match iOS 11 back buttons and doesn't behave correctly. It will be even harder to fix given iOS 11's different nav bar sizes. Instead just use Cancel buttons or the system back button everywhere instead.