Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an STPURLCallbackListener retain cycle. #846

Merged
merged 4 commits into from
Dec 12, 2017
Merged

Fix an STPURLCallbackListener retain cycle. #846

merged 4 commits into from
Dec 12, 2017

Commits on Dec 8, 2017

  1. Fix an STPURLCallbackListener retain cycle. 

    Previously there was a bug where STPURLCallbackListener retained its listeners, which meant that STPRedirectContext had a retain cycle and would not deallocate while it was actively listening for callbacks. Fixing this is in some ways a breaking API change.
This commit fixes the bug, and also updates the docs to explicitly mention that you need to retain the instances you make.
It also replaces referencing to STPAPIClient source polling (which is deprecated) and instead links to the sources best practices doc.
    @bdorfman-stripe
    bdorfman-stripe committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    bde01f5 View commit details
    Browse the repository at this point in the history

  2. Also fix strong ref cycle in start redirect flow method

    @bdorfman-stripe
    bdorfman-stripe committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    581a605 View commit details
    Browse the repository at this point in the history

  3. Disable fauxpas linting

    @bdorfman-stripe
    bdorfman-stripe committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    03ea51f View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2017

  1. Delete typ from changelog

    @bdorfman-stripe
    bdorfman-stripe committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    8b52451 View commit details
    Browse the repository at this point in the history