-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change minimum requirements to Xcode9 / iOS 9 #851
Merged
Merged
Commits on Dec 11, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 557a8bf - Browse repository at this point
Copy the full SHA 557a8bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 41522f5 - Browse repository at this point
Copy the full SHA 41522f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 707608a - Browse repository at this point
Copy the full SHA 707608aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4bbc22 - Browse repository at this point
Copy the full SHA f4bbc22View commit details -
Configuration menu - View commit details
-
Copy full SHA for b41f649 - Browse repository at this point
Copy the full SHA b41f649View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa96b4e - Browse repository at this point
Copy the full SHA aa96b4eView commit details -
Renable fauxpas for static target and disable APIAvailability
The faux pas 1.7.2 problem seems to only be with the dynamic framework target, so we can continue to lint the static lib target to get some checking done. Also disable the APIAvailability rule since with xcode 9 this is built in with `@available` (which FauxPas doesn't recognize)
Configuration menu - View commit details
-
Copy full SHA for f301970 - Browse repository at this point
Copy the full SHA f301970View commit details -
Audited all our `respondsToSelector` and FauxPas `APIAvailability` checks. Removed any unnecessary ones (now that we are on 9.0) and replaced all the relevant ones with `@available` checks instead.
Configuration menu - View commit details
-
Copy full SHA for 2da9894 - Browse repository at this point
Copy the full SHA 2da9894View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e06036 - Browse repository at this point
Copy the full SHA 2e06036View commit details
Commits on Dec 12, 2017
-
Use auto scroll content insetting
Our custom version doesn't work correctly on iOS11 and I don't see a reason to not just use the default system behavior for this.
Configuration menu - View commit details
-
Copy full SHA for 8a41e94 - Browse repository at this point
Copy the full SHA 8a41e94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91add43 - Browse repository at this point
Copy the full SHA 91add43View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae5899b - Browse repository at this point
Copy the full SHA ae5899bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 39d344f - Browse repository at this point
Copy the full SHA 39d344fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 26641ba - Browse repository at this point
Copy the full SHA 26641baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cd8541 - Browse repository at this point
Copy the full SHA 9cd8541View commit details -
Make it public correctly. Replace all existing manual fauxpas defines with header import. Remove unnecssary defines/imports.
Configuration menu - View commit details
-
Copy full SHA for 3ef1ebb - Browse repository at this point
Copy the full SHA 3ef1ebbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0788c85 - Browse repository at this point
Copy the full SHA 0788c85View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba65f9e - Browse repository at this point
Copy the full SHA ba65f9eView commit details -
Reverse product bundle identifier changes.
Despite Xcode recommending this change, it does not work correctly for some of our integration patterns. Thankfully our static framework validator CI script specifically checks for this case and yelled at me.
Configuration menu - View commit details
-
Copy full SHA for 8bcc8cb - Browse repository at this point
Copy the full SHA 8bcc8cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for c52130c - Browse repository at this point
Copy the full SHA c52130cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.