Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change minimum requirements to Xcode9 / iOS 9 #851

Merged
merged 20 commits into from
Dec 12, 2017
Merged

Change minimum requirements to Xcode9 / iOS 9 #851

merged 20 commits into from
Dec 12, 2017

Commits on Dec 11, 2017

  1. Bump minimum versions to 9

    @bdorfman-stripe
    bdorfman-stripe committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    557a8bf View commit details
    Browse the repository at this point in the history

  2. Remove all references to AddressBook framework

    @bdorfman-stripe
    bdorfman-stripe committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    41522f5 View commit details
    Browse the repository at this point in the history

  3. Remove iOS 9 availability guard

    @bdorfman-stripe
    bdorfman-stripe committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    707608a View commit details
    Browse the repository at this point in the history

  4. Change test platform version

    @bdorfman-stripe
    bdorfman-stripe committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    f4bbc22 View commit details
    Browse the repository at this point in the history

  5. Fix availability for geocoder

    @bdorfman-stripe
    bdorfman-stripe committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    b41f649 View commit details
    Browse the repository at this point in the history

  6. Re-enable availability warnings

    @bdorfman-stripe
    bdorfman-stripe committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    aa96b4e View commit details
    Browse the repository at this point in the history

  7. Renable fauxpas for static target and disable APIAvailability 

    The faux pas 1.7.2 problem seems to only be with the dynamic framework target, so we can continue to lint the static lib target to get some checking done.
Also disable the APIAvailability rule since with xcode 9 this is built in with `@available` (which FauxPas doesn't recognize)
    @bdorfman-stripe
    bdorfman-stripe committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    f301970 View commit details
    Browse the repository at this point in the history

  8. Fixup availability checks 

    Audited all our `respondsToSelector` and FauxPas `APIAvailability` checks. Removed any unnecessary ones (now that we are on 9.0) and replaced all the relevant ones with `@available` checks instead.
    @bdorfman-stripe
    bdorfman-stripe committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    2da9894 View commit details
    Browse the repository at this point in the history

  9. Change travis/tests to run on Xcode9/iOS11.2

    @bdorfman-stripe
    bdorfman-stripe committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    2e06036 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2017

  1. Use auto scroll content insetting 

    Our custom version doesn't work correctly on iOS11 and I don't see a reason to not just use the default system behavior for this.
    @bdorfman-stripe
    bdorfman-stripe committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    8a41e94 View commit details
    Browse the repository at this point in the history

  2. Extract working ViewController snapshot setup code into a helper

    @bdorfman-stripe
    bdorfman-stripe committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    91add43 View commit details
    Browse the repository at this point in the history

  3. Update view controller snapshot tests

    @bdorfman-stripe
    bdorfman-stripe committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    ae5899b View commit details
    Browse the repository at this point in the history

  4. Update migrating

    @bdorfman-stripe
    bdorfman-stripe committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    39d344f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into bdorfman-xcode9-ios9

    @bdorfman-stripe
    bdorfman-stripe authored Dec 12, 2017
    Configuration menu
    Copy the full SHA
    26641ba View commit details
    Browse the repository at this point in the history

  6. Update to Xcode 9.2 recommended project settings

    @bdorfman-stripe
    bdorfman-stripe committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    9cd8541 View commit details
    Browse the repository at this point in the history

  7. Fix FauxPas header 

    Make it public correctly.
Replace all existing manual fauxpas defines with header import.
Remove unnecssary defines/imports.
    @bdorfman-stripe
    bdorfman-stripe committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    3ef1ebb View commit details
    Browse the repository at this point in the history

  8. Update changelog to mention AddressBook

    @bdorfman-stripe
    bdorfman-stripe committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    0788c85 View commit details
    Browse the repository at this point in the history

  9. Fix fauxpas warning

    @bdorfman-stripe
    bdorfman-stripe committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    ba65f9e View commit details
    Browse the repository at this point in the history

  10. Reverse product bundle identifier changes. 

    Despite Xcode recommending this change, it does not work correctly for some of our integration patterns. Thankfully our static framework validator CI script specifically checks for this case and yelled at me.
    @bdorfman-stripe
    bdorfman-stripe committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    8bcc8cb View commit details
    Browse the repository at this point in the history

  11. Fix typo in MIGRATING

    @bdorfman-stripe
    bdorfman-stripe authored Dec 12, 2017
    Configuration menu
    Copy the full SHA
    c52130c View commit details
    Browse the repository at this point in the history