Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect Account tokenization #876

Merged
merged 13 commits into from
Jan 12, 2018
Merged

Commits on Jan 10, 2018

  1. Encode NSNumber-wrapped boolean values as true/false, not 1/0

    Adding a test to verify this works, and that this doesn't break other NSNumber instances
    that store 0 or 1.
    danj-stripe committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    8b3dc19 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2018

  1. Add STPAPIClient method for creating Connect Account tokens.

    It takes a single parameter, an `STPConnectAccountParams` object. This has an optional
    BOOL and an optional STPLegalEntityParams object (one of fields must be provided).
    
    Still TODO: adding `description` implementations in STPLegalEntityParams.m, and
    testing!
    danj-stripe committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    3f2bc39 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c9fd9ad View commit details
    Browse the repository at this point in the history
  3. Add STPConnectAccountFunctionalTests

    This currently fails, because `legal_entity` is actually required all the time, contrary
    to what I thought.
    danj-stripe committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    ef9cd23 View commit details
    Browse the repository at this point in the history
  4. Add STPFormEncodable tests for the new Params classes

    These are pretty basic, but then so are the implementations of the classes.
    
    I wanted to add custom Asserts (like https://www.objc.io/issues/15-testing/xctest/#custom-assert-macros)
    for these *very* repetitive tests (which already exist 4x times), but I think this is
    okay-ish.
    danj-stripe committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    b93b5ac View commit details
    Browse the repository at this point in the history
  5. Fix build - update Xcode project with location of public headers.

    Last night I had moved the public headers into the right directory to fix a different
    failure, and rebased that into 3f2bc39.
    
    Now that bg-stripe's reviewed this PR, not going to force-push anymore.
    danj-stripe committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    e8c13fe View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e3687de View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c5006f9 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    bec29a3 View commit details
    Browse the repository at this point in the history
  9. Add Faux Pas annotations to NSDateComponents<STPFormEncodable> conf…

    …ormance.
    
    Faux Pas (correctly) points out adding un-prefixed methods to a Foundation class via
    a category is dangerous. Probably a better thing to do is either prefix all of these
    methods in the protocol, or add custom support for `NSDateComponents` in
    `+[STPFormEncoder formEncodableValueForObject:]`.
    
    For now, I think this is safe enough.
    danj-stripe committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    b0fed36 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    64503a4 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    ee2a520 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    533ad2a View commit details
    Browse the repository at this point in the history