-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect Account tokenization #876
Commits on Jan 10, 2018
-
Encode NSNumber-wrapped boolean values as true/false, not 1/0
Adding a test to verify this works, and that this doesn't break other NSNumber instances that store 0 or 1.
Configuration menu - View commit details
-
Copy full SHA for 8b3dc19 - Browse repository at this point
Copy the full SHA 8b3dc19View commit details
Commits on Jan 11, 2018
-
Add STPAPIClient method for creating Connect Account tokens.
It takes a single parameter, an `STPConnectAccountParams` object. This has an optional BOOL and an optional STPLegalEntityParams object (one of fields must be provided). Still TODO: adding `description` implementations in STPLegalEntityParams.m, and testing!
Configuration menu - View commit details
-
Copy full SHA for 3f2bc39 - Browse repository at this point
Copy the full SHA 3f2bc39View commit details -
Configuration menu - View commit details
-
Copy full SHA for c9fd9ad - Browse repository at this point
Copy the full SHA c9fd9adView commit details -
Add STPConnectAccountFunctionalTests
This currently fails, because `legal_entity` is actually required all the time, contrary to what I thought.
Configuration menu - View commit details
-
Copy full SHA for ef9cd23 - Browse repository at this point
Copy the full SHA ef9cd23View commit details -
Add STPFormEncodable tests for the new Params classes
These are pretty basic, but then so are the implementations of the classes. I wanted to add custom Asserts (like https://www.objc.io/issues/15-testing/xctest/#custom-assert-macros) for these *very* repetitive tests (which already exist 4x times), but I think this is okay-ish.
Configuration menu - View commit details
-
Copy full SHA for b93b5ac - Browse repository at this point
Copy the full SHA b93b5acView commit details -
Fix build - update Xcode project with location of public headers.
Last night I had moved the public headers into the right directory to fix a different failure, and rebased that into 3f2bc39. Now that bg-stripe's reviewed this PR, not going to force-push anymore.
Configuration menu - View commit details
-
Copy full SHA for e8c13fe - Browse repository at this point
Copy the full SHA e8c13feView commit details -
Configuration menu - View commit details
-
Copy full SHA for e3687de - Browse repository at this point
Copy the full SHA e3687deView commit details -
Configuration menu - View commit details
-
Copy full SHA for c5006f9 - Browse repository at this point
Copy the full SHA c5006f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for bec29a3 - Browse repository at this point
Copy the full SHA bec29a3View commit details -
Add Faux Pas annotations to
NSDateComponents<STPFormEncodable>
conf……ormance. Faux Pas (correctly) points out adding un-prefixed methods to a Foundation class via a category is dangerous. Probably a better thing to do is either prefix all of these methods in the protocol, or add custom support for `NSDateComponents` in `+[STPFormEncoder formEncodableValueForObject:]`. For now, I think this is safe enough.
Configuration menu - View commit details
-
Copy full SHA for b0fed36 - Browse repository at this point
Copy the full SHA b0fed36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64503a4 - Browse repository at this point
Copy the full SHA 64503a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee2a520 - Browse repository at this point
Copy the full SHA ee2a520View commit details -
Configuration menu - View commit details
-
Copy full SHA for 533ad2a - Browse repository at this point
Copy the full SHA 533ad2aView commit details