Match cocoapods static analyzer settings, fix issues #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocoapods targets. We should fix these, so that anyone integrating with the SDK does not encounter analyzer issues.
… that matches. The request will fail to deserialize if the "object" key is nil and there are multiple deserializers that could be used. As far as I can tell, the only time there're multiple deserializers is `[STPCard, STPSource]`, neither of which have a nil `stripeObject`.
… comparing with `nil` These were all correct as-is, but making the comparison with nil explicit for readability and to suppress the issue when users integrate through Cocoapods.
|
👍 |
mludowise-stripe
pushed a commit
that referenced
this pull request
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Misuse of 'nonnull'and'Suspicious Conversions of NSNumber'are aggressive by defaultwhen using cocoapods. Adopts the same settings for our project.
Motivation
#895
Testing
Automated tests. There should be no functional changes from these commits.