Fix issue with apple pay token creation in PaymentContext #899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @danj-stripe
#893 introduced a regression where we unwrapped
token.card
one level upstream (before attaching to the customer, instead of beforedidCreatePaymentResult
). I should have QA'd this more thoroughly (I think I manually tested the apple pay sources flow, but not the apple pay token flow).Since this is pretty unintuitive, I've added comments explaining why we need to unwrap
token.card
. We unfortunately aren't really set up to unit test this code path right now.Fixes #898