Make iDEAL name parameter optional, and accept empty string as nil.
#940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When iDEAL support was originally implemented in the iOS SDK, this was a required parameter. It isn't any more. I considered removing the `name:` parameter completely, but this maintains backwards compatibility. Also handling the empty string the same as `nil` for these optional fields, so that there isn't a surprise waiting. IMO, an optional field that contains the empty string shouldn't cause the request to fail.
|
Maybe we need to add a changelog entry saying something like: "Creating iDEAL sources no longer requires |
joeydong-stripe
approved these changes
May 21, 2018
mludowise-stripe
pushed a commit
that referenced
this pull request
Apr 2, 2022
* Add Link Notice component * Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I considered removing the
name:parameter completely, but this maintains backwardscompatibility, by just marking it as nullable/optional.
Also handling the empty string the same as
nilfor these optional fields, so that thereisn't a surprise waiting. IMO, an optional field that contains the empty string shouldn't
cause the request to fail.
Motivation
When iDEAL support was originally implemented in the iOS SDK, this was a required
parameter. It isn't any more.
IOS-739
Testing
Added a couple of functional tests that exercise this case.