update vscode recommended extensions (#1849)

.vscode/extensions.json

@@ -1,8 +1,14 @@
 {
   "recommendations": [
     "EditorConfig.editorconfig", // default
-    "vscjava.vscode-java-pack", // intellisense and tooling
-    "richardwillis.vscode-spotless-gradle", // formatting
-    "naco-siren.gradle-language" // also, gradle
+    "redhat.java", // LSP
+    "vscjava.vscode-java-debug", // debugger
+    "vscjava.vscode-gradle", // gradle support
+    "vscjava.vscode-java-test", // test runner
+    "richardwillis.vscode-spotless-gradle" // formatting
+  ],
+  "unwantedRecommendations": [
+    "naco-siren.gradle-language", // old gradle
+    "vscjava.vscode-java-pack" // has extra stuff, we've pulled the important parts out above
   ]
 }

.vscode/settings.json

@@ -7,7 +7,8 @@
     "editor.rulers": [100],
     // use spotless for formatting (to match makefile)
     "spotlessGradle.format.enable": true,
-    "spotlessGradle.diagnostics.enable": true,
+    // don't show formatting issues as errors, just fix on save
+    "spotlessGradle.diagnostics.enable": false,
     "editor.defaultFormatter": "richardwillis.vscode-spotless-gradle",
     "editor.codeActionsOnSave": {
       "source.fixAll.spotlessGradle": "explicit",