Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Custom Checkout types #500

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Update Custom Checkout types #500

merged 2 commits into from
Sep 12, 2023

Conversation

danwang-stripe
Copy link
Contributor

r? @pololi-stripe

Summary & motivation

Updates the types for Custom Checkout:

  1. country in StripeCustomCheckoutAddress is required
  2. I removed all the undefined types (?) in objects that are read-only. The remaining types that allow omitting keys are only the ones that are used in a parameter for some function, such as address or elements options
  3. Renamed ShippingAddress and BillingAddress to Contact
  4. Replaced LineItemDiscountAmount with DiscountAmount

Testing & documentation

@danwang-stripe danwang-stripe merged commit e726a4f into master Sep 12, 2023
1 check passed
@danwang-stripe danwang-stripe deleted the danwang/update-custom-checkout-types branch September 12, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pololi-stripe pololi-stripe pololi-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danwang-stripe @pololi-stripe