Add types for Confirmation Token GA #556
Conversation
| billing_details?: PaymentMethodCreateParams.BillingDetails; | ||
| }; | ||
|
|
||
| /** |
There was a problem hiding this comment.
highlight: payment_method is removed
| phone?: string | null; | ||
| } | ||
|
|
||
| export interface PaymentMethodPreview { |
There was a problem hiding this comment.
These are all copied from payment-methods.d.ts
| /** | ||
| * The customer's billing details. | ||
| */ | ||
| billing_details?: PaymentMethodCreateParams.BillingDetails; |
There was a problem hiding this comment.
Should allow_redisplay be added with this PR?
tests/types/src/invalid.ts
Outdated
| if (result.error) { | ||
| return console.log(result.error.code); | ||
| } |
There was a problem hiding this comment.
we should probably remove this console.log?
There was a problem hiding this comment.
The file doesn't seem to be run and a bunch of console.logs are throughout the file, so I was just copying how others were doing it.
(I believe they just run a typescript checker over it)
There was a problem hiding this comment.
hmm i could see some in tests/types/src/valid.ts but not here. I think we should just remove console.log here and keep in the file?
There was a problem hiding this comment.
Yeah, i'll remove it then
| /** | ||
| * The customer's billing details. | ||
| */ | ||
| billing_details?: PaymentMethodCreateParams.BillingDetails; |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Summary & motivation
Added types for Confirmation Tokens.
Testing & documentation
Tested