Remove window declarations from pure types #560
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & motivation
This PR fixes an issue from this comment: #543 (comment)
Both
pure/index.d.ts
anddist/index.d.ts
attempt to modify theWindow
class. Thetypes/pure.d.ts
importsloadStripe
fromtypes/index.d.ts
, and the latter module monkeypatchesWindow
. Thepure
module then receives both the function type it wants, as well as the monkeypatchedWindow
class.I have fixed the issue by moving the
loadStripe
declaration into a newshared.d.ts
module.Testing & documentation
I built the types and verified that
Window
is no longer monkeypatched in thepure
output types.