Null out empty data sent to GET/DELETE APIs (#2172)

stripe · Sep 12, 2024 · 272799e · 272799e
1 parent 16d137e
commit 272799e
Show file tree

Hide file tree

Showing 60 changed files with 176 additions and 176 deletions.
diff --git a/src/StripeResource.ts b/src/StripeResource.ts
@@ -178,7 +178,7 @@ StripeResource.prototype = {
     }
 
     const dataInQuery = spec.method === 'GET' || spec.method === 'DELETE';
-    const bodyData = dataInQuery ? {} : data;
+    const bodyData = dataInQuery ? null : data;
     const queryData = dataInQuery ? data : {};
 
     return {

diff --git a/src/Types.d.ts b/src/Types.d.ts
@@ -61,7 +61,7 @@ export type RequestOptions = {
 export type RequestOpts = {
   requestMethod: string;
   requestPath: string;
-  bodyData: RequestData;
+  bodyData: RequestData | null;
   queryData: RequestData;
   auth: string | null;
   headers: RequestHeaders;
@@ -155,7 +155,7 @@ export type RequestSender = {
     method: string,
     host: string | null,
     path: string,
-    data: RequestData,
+    data: RequestData | null,
     auth: string | null,
     options: RequestOptions,
     usage: Array<string>,

diff --git a/test/resources/Account.spec.js b/test/resources/Account.spec.js
@@ -33,7 +33,7 @@ describe('Account Resource', () => {
       expect(stripe.LAST_REQUEST).to.deep.equal({
         method: 'DELETE',
         url: '/v1/accounts/acct_16Tzq6DBahdM4C8s',
-        data: {},
+        data: null,
         headers: {},
         settings: {},
       });
@@ -59,7 +59,7 @@ describe('Account Resource', () => {
       expect(stripe.LAST_REQUEST).to.deep.equal({
         method: 'GET',
         url: '/v1/account',
-        data: {},
+        data: null,
         headers: {},
         settings: {},
       });
@@ -70,7 +70,7 @@ describe('Account Resource', () => {
       expect(stripe.LAST_REQUEST).to.deep.equal({
         method: 'GET',
         url: '/v1/accounts/foo',
-        data: {},
+        data: null,
         headers: {},
         settings: {},
       });
@@ -83,7 +83,7 @@ describe('Account Resource', () => {
         auth: key,
         method: 'GET',
         url: '/v1/account',
-        data: {},
+        data: null,
         headers: {},
         settings: {},
       });
@@ -96,7 +96,7 @@ describe('Account Resource', () => {
         auth: params.apiKey,
         method: 'GET',
         url: '/v1/account',
-        data: {},
+        data: null,
         headers: {},
         settings: {},
       });
@@ -107,7 +107,7 @@ describe('Account Resource', () => {
       expect(stripe.LAST_REQUEST).to.deep.equal({
         method: 'GET',
         url: '/v1/account',
-        data: {},
+        data: null,
         headers: {},
         settings: {},
       });
@@ -122,7 +122,7 @@ describe('Account Resource', () => {
           method: 'GET',
           url: '/v1/accounts/acct_123/capabilities',
           headers: {},
-          data: {},
+          data: null,
           settings: {},
         });
       });
@@ -133,7 +133,7 @@ describe('Account Resource', () => {
           method: 'GET',
           url: '/v1/accounts/acct_123/capabilities',
           headers: {},
-          data: {},
+          data: null,
           auth: TEST_AUTH_KEY,
           settings: {},
         });
@@ -147,7 +147,7 @@ describe('Account Resource', () => {
           method: 'GET',
           url: '/v1/accounts/acct_123/capabilities/acap_123',
           headers: {},
-          data: {},
+          data: null,
           settings: {},
         });
       });
@@ -162,7 +162,7 @@ describe('Account Resource', () => {
           method: 'GET',
           url: '/v1/accounts/acct_123/capabilities/acap_123',
           headers: {},
-          data: {},
+          data: null,
           auth: TEST_AUTH_KEY,
           settings: {},
         });
@@ -216,7 +216,7 @@ describe('Account Resource', () => {
           url:
             '/v1/accounts/accountIdFoo321/external_accounts/externalAccountIdFoo456',
           headers: {},
-          data: {},
+          data: null,
           settings: {},
         });
       });
@@ -232,7 +232,7 @@ describe('Account Resource', () => {
           url:
             '/v1/accounts/accountIdFoo321/external_accounts/externalAccountIdFoo456',
           headers: {},
-          data: {},
+          data: null,
           auth: TEST_AUTH_KEY,
           settings: {},
         });
@@ -307,7 +307,7 @@ describe('Account Resource', () => {
           url:
             '/v1/accounts/accountIdFoo321/external_accounts/externalAccountIdFoo456',
           headers: {},
-          data: {},
+          data: null,
           settings: {},
         });
       });
@@ -323,7 +323,7 @@ describe('Account Resource', () => {
           url:
             '/v1/accounts/accountIdFoo321/external_accounts/externalAccountIdFoo456',
           headers: {},
-          data: {},
+          data: null,
           auth: TEST_AUTH_KEY,
           settings: {},
         });
@@ -337,7 +337,7 @@ describe('Account Resource', () => {
           method: 'GET',
           url: '/v1/accounts/accountIdFoo321/external_accounts',
           headers: {},
-          data: {},
+          data: null,
           settings: {},
         });
       });
@@ -348,7 +348,7 @@ describe('Account Resource', () => {
           method: 'GET',
           url: '/v1/accounts/accountIdFoo321/external_accounts',
           headers: {},
-          data: {},
+          data: null,
           auth: TEST_AUTH_KEY,
           settings: {},
         });
@@ -379,7 +379,7 @@ describe('Account Resource', () => {
           method: 'GET',
           url: '/v1/accounts/acct_123/persons/person_123',
           headers: {},
-          data: {},
+          data: null,
           settings: {},
         });
       });
@@ -390,7 +390,7 @@ describe('Account Resource', () => {
           method: 'GET',
           url: '/v1/accounts/acct_123/persons/person_123',
           headers: {},
-          data: {},
+          data: null,
           auth: TEST_AUTH_KEY,
           settings: {},
         });
@@ -471,7 +471,7 @@ describe('Account Resource', () => {
           method: 'DELETE',
           url: '/v1/accounts/acct_123/persons/person_123',
           headers: {},
-          data: {},
+          data: null,
           settings: {},
         });
       });
@@ -482,7 +482,7 @@ describe('Account Resource', () => {
           method: 'DELETE',
           url: '/v1/accounts/acct_123/persons/person_123',
           headers: {},
-          data: {},
+          data: null,
           auth: TEST_AUTH_KEY,
           settings: {},
         });
@@ -496,7 +496,7 @@ describe('Account Resource', () => {
           method: 'GET',
           url: '/v1/accounts/acct_123/persons',
           headers: {},
-          data: {},
+          data: null,
           settings: {},
         });
       });
@@ -507,7 +507,7 @@ describe('Account Resource', () => {
           method: 'GET',
           url: '/v1/accounts/acct_123/persons',
           headers: {},
-          data: {},
+          data: null,
           auth: TEST_AUTH_KEY,
           settings: {},
         });

diff --git a/test/resources/ApplePayDomains.spec.js b/test/resources/ApplePayDomains.spec.js
@@ -11,7 +11,7 @@ describe('ApplePayDomains Resource', () => {
         method: 'GET',
         url: '/v1/apple_pay/domains/apwc_retrieve',
         headers: {},
-        data: {},
+        data: null,
         settings: {},
       });
     });
@@ -24,7 +24,7 @@ describe('ApplePayDomains Resource', () => {
         method: 'DELETE',
         url: '/v1/apple_pay/domains/apwc_delete',
         headers: {},
-        data: {},
+        data: null,
         settings: {},
       });
     });
@@ -55,7 +55,7 @@ describe('ApplePayDomains Resource', () => {
         method: 'GET',
         url: '/v1/apple_pay/domains',
         headers: {},
-        data: {},
+        data: null,
         settings: {},
       });
     });

diff --git a/test/resources/ApplicationFees.spec.js b/test/resources/ApplicationFees.spec.js
@@ -10,7 +10,7 @@ describe('ApplicationFee Resource', () => {
       expect(stripe.LAST_REQUEST).to.deep.equal({
         method: 'GET',
         url: '/v1/application_fees',
-        data: {},
+        data: null,
         headers: {},
         settings: {},
       });
@@ -50,7 +50,7 @@ describe('ApplicationFee Resource', () => {
       expect(stripe.LAST_REQUEST).to.deep.equal({
         method: 'GET',
         url: '/v1/application_fees/appFeeIdExample3242/refunds',
-        data: {},
+        data: null,
         headers: {},
         settings: {},
       });
@@ -65,7 +65,7 @@ describe('ApplicationFee Resource', () => {
         method: 'GET',
         url:
           '/v1/application_fees/appFeeIdExample3242/refunds/refundIdExample2312',
-        data: {},
+        data: null,
         headers: {},
         settings: {},
       });

diff --git a/test/resources/Balance.spec.js b/test/resources/Balance.spec.js
@@ -10,7 +10,7 @@ describe('Balance Resource', () => {
       expect(stripe.LAST_REQUEST).to.deep.equal({
         method: 'GET',
         url: '/v1/balance',
-        data: {},
+        data: null,
         headers: {},
         settings: {},
       });
@@ -21,7 +21,7 @@ describe('Balance Resource', () => {
       expect(stripe.LAST_REQUEST).to.deep.equal({
         method: 'GET',
         url: '/v1/balance',
-        data: {},
+        data: null,
         auth: 'aGN0bIwXnHdw5645VABjPdSn8nWY7G11',
         headers: {},
         settings: {},

diff --git a/test/resources/BalanceTransactions.spec.js b/test/resources/BalanceTransactions.spec.js
@@ -11,7 +11,7 @@ describe('BalanceTransactions Resource', function() {
         method: 'GET',
         url: '/v1/balance_transactions/txn_123',
         headers: {},
-        data: {},
+        data: null,
         settings: {},
       });
     });
@@ -24,7 +24,7 @@ describe('BalanceTransactions Resource', function() {
         method: 'GET',
         url: '/v1/balance_transactions',
         headers: {},
-        data: {},
+        data: null,
         settings: {},
       });
     });

diff --git a/test/resources/BillingPortal/Configurations.spec.js b/test/resources/BillingPortal/Configurations.spec.js
@@ -52,7 +52,7 @@ describe('BillingPortal', () => {
           method: 'GET',
           url: '/v1/billing_portal/configurations/bpc_123',
           headers: {},
-          data: {},
+          data: null,
           settings: {},
         });
       });
@@ -64,7 +64,7 @@ describe('BillingPortal', () => {
           method: 'GET',
           url: '/v1/billing_portal/configurations',
           headers: {},
-          data: {},
+          data: null,
           settings: {},
         });
       });

diff --git a/test/resources/Charges.spec.js b/test/resources/Charges.spec.js
@@ -10,7 +10,7 @@ describe('Charge Resource', () => {
       expect(stripe.LAST_REQUEST).to.deep.equal({
         method: 'GET',
         url: '/v1/charges/chargeIdFoo123',
-        data: {},
+        data: null,
         headers: {},
         settings: {},
       });
@@ -52,7 +52,7 @@ describe('Charge Resource', () => {
       expect(stripe.LAST_REQUEST).to.deep.equal({
         method: 'GET',
         url: '/v1/charges',
-        data: {},
+        data: null,
         headers: {},
         settings: {},
       });

diff --git a/test/resources/Checkout/Sessions.spec.js b/test/resources/Checkout/Sessions.spec.js
@@ -45,7 +45,7 @@ describe('Checkout', () => {
         expect(stripe.LAST_REQUEST).to.deep.equal({
           method: 'GET',
           url: '/v1/checkout/sessions/cs_123',
-          data: {},
+          data: null,
           headers: {},
           settings: {},
         });
@@ -59,7 +59,7 @@ describe('Checkout', () => {
           method: 'GET',
           url: '/v1/checkout/sessions/cs_123/line_items',
           headers: {},
-          data: {},
+          data: null,
           settings: {},
         });
       });

diff --git a/test/resources/CountrySpecs.spec.js b/test/resources/CountrySpecs.spec.js
@@ -10,7 +10,7 @@ describe('CountrySpecs Resource', () => {
       expect(stripe.LAST_REQUEST).to.deep.equal({
         method: 'GET',
         url: '/v1/country_specs',
-        data: {},
+        data: null,
         headers: {},
         settings: {},
       });
@@ -24,7 +24,7 @@ describe('CountrySpecs Resource', () => {
       expect(stripe.LAST_REQUEST).to.deep.equal({
         method: 'GET',
         url: `/v1/country_specs/${country}`,
-        data: {},
+        data: null,
         headers: {},
         settings: {},
       });