Use standard Typescript AsyncIterator types #1745
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1739 (comment).
I was originally going to make the iterator return
{done: true}
instead of{done: true, value: undefined}
(which would have been a breaking change), but it turns out thatvalue: undefined
is actually the standard:And it turns out that we can use the standard Typescript types for iterators/async iterators instead of defining our own. https://github.com/microsoft/TypeScript/blob/main/src/lib/es2015.iterable.d.ts#L11-L28
Doing this is nonbreaking.