Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add codeowners #2160

Merged
merged 5 commits into from
Aug 20, 2024
Merged

Add codeowners #2160

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
93466a3
add codeowners file
xavdid-stripe Aug 19, 2024
fa17fd2
update team
xavdid-stripe Aug 19, 2024
65f0362
update again
xavdid-stripe Aug 19, 2024
6a5670e
Merge branch 'master' into add-codeowners
xavdid-stripe Aug 19, 2024
2dbbc4f
Merge branch 'master' into add-codeowners
prathmesh-stripe Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# All files should be reviewed by a member of the SDKs team
* @stripe/api-library-reviewers
xavdid-stripe marked this conversation as resolved.
Show resolved Hide resolved
10 changes: 4 additions & 6 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,16 @@
"editor.formatOnSave": true,

"typescript.updateImportsOnFileMove.enabled": "always",
"[typescript]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},

"javascript.updateImportsOnFileMove.enabled": "always",
"[javascript]": {
"[typescript][javascript]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},

// Extension settings
"npm.packageManager": "yarn",
"editor.codeActionsOnSave": {
"source.fixAll.eslint": "explicit"
"source.fixAll.eslint": "explicit",
// eslint handles import sorting, don't let VSCode fight it
"source.organizeImports": "never"
}
}
Loading