Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta: codegenned async methods on resources #1171

Merged
merged 9 commits into from
Feb 5, 2024

Conversation

richardm-stripe
Copy link
Contributor

@richardm-stripe richardm-stripe commented Dec 13, 2023

Summary

Includes #1219 - review that first for non-codegenned portion.

Adds (codegenned) _async mirrors for resource methods. (See codegen)
Adds _async mirrors for certain infrastructure methods. (See [add more infra)

Notes

  • No .request_stream_async yet. Needed for completeness, but can happen in a follow-up.

Testing

Generated tests

@richardm-stripe richardm-stripe marked this pull request as ready for review February 3, 2024 02:18
@richardm-stripe richardm-stripe requested review from a team and helenye-stripe and removed request for a team February 3, 2024 02:18
Copy link
Contributor

@anniel-stripe anniel-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No .request_stream_async yet. Needed for completeness, but can happen in a follow-up.

I saw request_stream_async was added in #1219 to APIRequestor / StripeObject, why are we omitting it here?

@richardm-stripe richardm-stripe merged commit 289ca89 into beta Feb 5, 2024
15 checks passed
@xavdid-stripe xavdid-stripe deleted the richardm-async-codegen branch May 10, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants