Catch Exception instead of using bare except
#357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be new, but flake8 is complaining that we're using a bare
except and it's breaking the build:
flake8 stripe
stripe/webhook.py:48:9: E722 do not use bare except'
Here we change over to catch the parent `Exception` class instead.
|
Wonder how this passed before, but lgtm! |
Yeah seriously! All I can think of is that the default Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be new, but flake8 is complaining that we're using a bare
except and it's breaking the build:
Here we change over to catch the parent
Exceptionclass instead.r? @ob-stripe