Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code #399

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe
cc @stripe/api-libraries

Cleanup for version 2.0:

  • remove bin/stripe client
  • remove a lot of deprecated methods in APIRequestor
  • remove deprecated all() method for list requests (the proper method is list())
  • remove legacy subscription management methods in Customer
  • remove support for api_version argument in EphemeralKey.create() (the proper argument is stripe_version)
  • remove delete() method in Source (the proper method is detach())
  • remove the comment about removing arg in delete_discount() methods in Customer and Subscription. Instead, support sending params to the API. (Those methods currently don't take accept any parameters, but generally the library doesn't try to enforce which methods support parameters and which don't. Invalid arguments will be declined server-side.)
  • remove warning on StripeObject.to_dict(). The method is trivial, might as well keep supporting it.
  • clean up global stripe namespace. Invididual exception classes are no longer imported directly in the global namespaces, as well as other internal classes and methods.

@@ -1,344 +0,0 @@
#!/usr/bin/env python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geeze, I didn't even know this was a thing.

@brandur-stripe
Copy link
Contributor

Amazing that you've been keeping track of all these little inconsistencies all along. Nice!

LGTM.

@ob-stripe
Copy link
Contributor Author

Amazing that you've been keeping track of all these little inconsistencies all along.

Haha, tbh I mostly grep'd for "deprec", "warnings", "TODO", etc. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants