Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add google places sdk to app/build.gradle with expo config plugin #1564

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

erickreutz
Copy link

Summary

Adds enableGooglePlacesSdk as an option for Expos config plugin to add the Google Places SDK to app/build.gradle as a dependency

Motivation

I'm making this change so I can use the <AddressSheet /> on Android with autocomplete enabled in an Expo project

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2023

CLA assistant check
All committers have signed the CLA.


if (buildGradle.includes('dependencies {')) {
return buildGradle.replace(
'dependencies {',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't some apps' build.gradle have >1 dependencies {} block?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants