Allow templating when loading configs. #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnavdugar-stripe
force-pushed
the
arnavdugar/config
branch
from
5b49f6c to
1d09f7b
Compare
Comment on lines
+36
to
+40
| go func() { | ||
| err := configTemplate.Execute(configWriter, templateData) | ||
| configWriter.Close() | ||
| templateErr <- err | ||
| }() |
There was a problem hiding this comment.
Why did you want to do this in a goroutine? My initial reaction is this should be synchronous.
There was a problem hiding this comment.
Ahh I see the example on io.Pipe
mimran-stripe
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow templating when loading configs.