Deduplicating add tags #1009
Merged
Deduplicating add tags #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnavdugar-stripe
approved these changes
Nov 29, 2022
andresgalindo-stripe
added a commit
that referenced
this pull request
Nov 30, 2022
When metrics are going through the globalization pipeline metrics from veneur local will have tags added to them by the `add_tags` functionality when these same metrics arrive at the globalization pipeline if veneur global has its own `add_tags` specified that overlap with those from veneur local we would end up with duplicate tags. See the original fix [here](#1009). As to why this PR: when accessing a substring of ft where `len(k)` is longer than `ft` itself we'll receive an out of bounds error, I was operating under the assumption they'd behave a lot like python strings where this behavior is valid: ``` Python 3.9.11 (main, Sep 13 2022, 16:05:34) [Clang 13.1.6 (clang-1316.0.21.2.5)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> foo = "test" >>> foo[0:20] 'test' ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
add_tagsbehavior to replace elements in the slice with the same key, if they exist, otherwise default to append.Motivation
Using
add_tagscan cause us to have tags with duplicate keys (though different values), this has not been a problem because most of the sinks will transform the slice into a map which will naturally "dedupe". However, it causes a problem when we're using themax_tagsconfiguration because now we don't have an accurate accounting of the number of tags.This doesn't solve the problem of the metric being emitted with duplicate tags but that isn't something we've observed happens often.
Test plan
Unit test.
Rollout/monitoring/revert plan