Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add workaround for what seems to be a Node 7.7.2 regression:
net.createConnection(port)
is failing with the following error, see e.g. https://travis-ci.org/strongloop/loopback/jobs/209262349:The same code passes on Node 7.7.1, see e.g. https://travis-ci.org/strongloop/loopback/jobs/209009746.
My proposed workaround is to explicitly pass a no-op callback argument:
Strangely enough, the problem CANNOT be reproduced when the failing test is run in isolation via
mocha test/integration.test.js
. To reproduce it, one has to add few more tests making HTTP requests, e.g. viaFrom looking at recent Node.js changes, it seems the problem was introduced by nodejs/node@b56e851 from nodejs/node#11667.
@joyeecheung @mcollina @jasnell you have authored/reviewed that patch, do you happen to have any insights on what may be wrong here?
cc @sam-github