Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow promises to resolve with a single arg #180

Merged
merged 1 commit into from
Feb 13, 2015

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Feb 13, 2015

A follow-up for #179, connect strongloop/loopback#418

Comparison of callback and promise APIs:

callback(null, value) <===> resolve(value)
callback(null, arg1, arg2) <===> resolve([arg1, arg2])

/to @raymondfeng @ritch please review

@raymondfeng
Copy link
Member

LGTM

bajtos added a commit that referenced this pull request Feb 13, 2015
…gle-value

Allow promises to resolve with a single arg
@bajtos bajtos merged commit ea18e72 into master Feb 13, 2015
@altsang altsang removed the #review label Feb 13, 2015
@bajtos bajtos deleted the fix/promise-resolved-with-single-value branch February 13, 2015 23:25
@raymondfeng raymondfeng assigned bajtos and unassigned raymondfeng Feb 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants