Removes duplicate property.

structurizr · Oct 27, 2023 · a6b55e6 · a6b55e6
1 parent 670617e
commit a6b55e6
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 4 deletions.
diff --git a/src/main/java/com/structurizr/export/plantuml/AbstractPlantUMLExporter.java b/src/main/java/com/structurizr/export/plantuml/AbstractPlantUMLExporter.java
@@ -23,6 +23,7 @@ public abstract class AbstractPlantUMLExporter extends AbstractDiagramExporter {
     public static final String PLANTUML_TITLE_PROPERTY = "plantuml.title";
     public static final String PLANTUML_INCLUDES_PROPERTY = "plantuml.includes";
     public static final String PLANTUML_ANIMATION_PROPERTY = "plantuml.animation";
+    public static final String PLANTUML_SEQUENCE_DIAGRAM_PROPERTY = "plantuml.sequenceDiagram";
 
     private static final double MAX_ICON_SIZE = 30.0;
 

diff --git a/src/main/java/com/structurizr/export/plantuml/C4PlantUMLExporter.java b/src/main/java/com/structurizr/export/plantuml/C4PlantUMLExporter.java
@@ -21,7 +21,6 @@ public class C4PlantUMLExporter extends AbstractPlantUMLExporter {
     public static final String C4PLANTUML_STANDARD_LIBRARY_PROPERTY = "c4plantuml.stdlib";
     public static final String C4PLANTUML_SPRITE = "c4plantuml.sprite";
     public static final String C4PLANTUML_SHADOW = "c4plantuml.shadow";
-    public static final String C4PLANTUML_SEQUENCE_DIAGRAM_PROPERTY = "plantuml.sequenceDiagram";
 
     /**
      * <p>Set this property to <code>true</code> by calling {@link Configuration#addProperty(String, String)} in your
@@ -674,7 +673,7 @@ protected boolean usePlantUMLStandardLibrary(ModelView view) {
     }
 
     protected boolean renderAsSequenceDiagram(ModelView view) {
-        return view instanceof DynamicView && "true".equalsIgnoreCase(getViewOrViewSetProperty(view, C4PLANTUML_SEQUENCE_DIAGRAM_PROPERTY, "false"));
+        return view instanceof DynamicView && "true".equalsIgnoreCase(getViewOrViewSetProperty(view, PLANTUML_SEQUENCE_DIAGRAM_PROPERTY, "false"));
     }
 
 }
diff --git a/src/main/java/com/structurizr/export/plantuml/StructurizrPlantUMLExporter.java b/src/main/java/com/structurizr/export/plantuml/StructurizrPlantUMLExporter.java
@@ -14,7 +14,6 @@
 
 public class StructurizrPlantUMLExporter extends AbstractPlantUMLExporter {
 
-    public static final String PLANTUML_SEQUENCE_DIAGRAM_PROPERTY = "plantuml.sequenceDiagram";
     public static final String PLANTUML_SHADOW = "plantuml.shadow";
 
     private int groupId = 0;

diff --git a/src/test/java/com/structurizr/export/plantuml/C4PlantUMLDiagramExporterTests.java b/src/test/java/com/structurizr/export/plantuml/C4PlantUMLDiagramExporterTests.java
@@ -53,7 +53,7 @@ public void test_BigBankPlcExample() throws Exception {
         assertEquals(expected, diagram.getDefinition());
 
         // and the sequence diagram version
-        workspace.getViews().getConfiguration().addProperty(exporter.C4PLANTUML_SEQUENCE_DIAGRAM_PROPERTY, "true");
+        workspace.getViews().getConfiguration().addProperty(exporter.PLANTUML_SEQUENCE_DIAGRAM_PROPERTY, "true");
         diagrams = exporter.export(workspace);
         diagram = diagrams.stream().filter(d -> d.getKey().equals("SignIn")).findFirst().get();
         expected = readFile(new File("./src/test/java/com/structurizr/export/plantuml/c4plantuml/36141-SignIn-sequence.puml"));