Skip to content
This repository has been archived by the owner on Jan 28, 2022. It is now read-only.

Migrating to Swift 4.2/Xcode 10 #1

Merged
merged 13 commits into from
Feb 12, 2019
Merged

Migrating to Swift 4.2/Xcode 10 #1

merged 13 commits into from
Feb 12, 2019

Conversation

RomanPodymov
Copy link
Contributor

Good evening.
Thank you for this library, it looks very interesting.
I'd like to add support of Swift 4.2 for the localizenib-ios and here is what I did:

  • Set Swift version to 4.2;
  • Added Gemfile for easier installation of dependencies written in Ruby;
  • Clean code with swiftlint autocorrect;
  • Declared "!!!" as a computable property;
  • Fixed all warnings.

@RomanPodymov RomanPodymov changed the title Migration to Swift 4.2/Xcode 10 Migrating to Swift 4.2/Xcode 10 Oct 13, 2018
@jankaltoun
Copy link

Hi Roman, thank you for your contribution!

@dzindra please take a look.

Copy link
Contributor

@dzindra dzindra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Roman, thanks for your pull request. I checked it and commented on some changes you made. Also when I try to compile code, it fails on UIControlState type changed in Swift 4.2. Please address the issues and I will merge your PR.

https://github.com/RomanPodymov/localizenib-ios/blob/d3e4a12133e713d97fc41792935249987dbb53de/LocalizeNIB/LocalizeNIB.swift#L172

LocalizeNIB/LocalizeNIB.swift Outdated Show resolved Hide resolved
LocalizeNIB/LocalizeNIB.swift Outdated Show resolved Hide resolved
Gemfile Outdated Show resolved Hide resolved
@dzindra dzindra merged commit ef3cc79 into strvcom:master Feb 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants