Refactor config files #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #260.
We can retrieve the default color from the appearance config instead. We don't have getter functions to retrieve other preferences, so it seems unnecessary to have one for the colors alone.
|
Noting two potential improvements for the future (that each require changes in Genesis):
|
This allows them to be referenced inside the returned array, preventing a PHP warning.
config/appearance.php
Outdated
| 'color' => get_theme_mod( 'genesis_sample_accent_color', genesis_sample_get_default_color( 'accent' ) ), | ||
| 'color' => get_theme_mod( | ||
| 'genesis_sample_accent_color', | ||
| $genesis_sample_default_colors['accent'] |
There was a problem hiding this comment.
Should this be defined earlier like the link color for consistency?
$genesis_sample_accent_color = get_theme_mod(
'genesis_sample_accent_color',
$genesis_sample_default_colors['accent']
);
config/appearance.php
Outdated
| @@ -18,6 +27,7 @@ | |||
| 'default-button-bg' => $genesis_sample_link_color, | |||
There was a problem hiding this comment.
Doesn't have to be for this PR, but for each default- here, they aren't always "default" once the colors are changed. Perhaps we should look at renaming these?
|
@dreamwhisper Thanks for your review. I like both changes you suggested and have updated this PR. |
This ensures widget areas get added.
dreamwhisper
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #260.
child-theme-settings.phpinstead of renaming it todefaults.phpas intended, because it's hard-coded and auto-loaded by Genesis: https://github.com/studiopress/genesis/blob/8899887473437ba5a0a017b0214da9e17a009677/lib/admin/onboarding/theme-activation.php#L53genesis_sample_get_default_color()in favor of fetching the default colors from the config directly. (We don't have getter functions for other configuration data, so it seems unnecessary to have one for the colors.)