Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require linked-hash-map v0.5.3 (or a newer patch version) #22

Closed

Conversation

austinjones
Copy link

Hi @stusmall,
I found an issue with the linked_hash_map dependency on <= v0.5.2. linked-hash-map can panic due to the UB checks implemented in Rust 1.48 (rust-lang/rust#66151, as it uses std::mem::uninitialized:

v0.5.3 fixes the issue (contain-rs/linked-hash-map#100). This PR adds a requirement on v0.5.3 (or a newer patch version).

This commit requires linked-hash-map to include contain-rs/linked-hash-map#100

When linked-hash-map is on v0.5.2, ttl_cache can panic due to the UB checks implemented in Rust 1.48: rust-lang/rust#66151
@stusmall
Copy link
Owner

stusmall commented Dec 5, 2020

If a library consuming ttl_cache as is runs cargo update they will pick up the 0.5.3 version of linked-hash-map. If they aren't updating their dependencies then any change here won't help them anyways. Ultimately updating to the latest patch version of a dependency should be the responsibility of the final consumer of the library, and not intermediate libraries in the dependency graph.

Tell every at ThreatX I said hi :)

@stusmall stusmall closed this Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants