prefix all componentId with sc-
#276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
quantizor
reviewed
Jul 29, 2020
| "@babel/plugin-proposal-class-properties": "^7.4.4", | ||
| "@babel/preset-env": "^7.4.5", | ||
| "@babel/preset-env": "^7.8.7", |
There was a problem hiding this comment.
please drop unrelated changes, thanks
|
@probablyup i believe this can be closed, since there is the `namespace' option that parameterizes this now |
|
I believe this is obsolete now given: #281 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously componentId would only be prefixed with
sc-when component hash began with a digit. This differs from styled-components componentId generation where all componentIds are prefixed withsc-This patch causes all componentId to be prefixed with
sc-Additionally, I have updated the build dependancies and rebuilt yarn.lock