Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limiting the scope of plugin files. #80

Merged
merged 2 commits into from
Oct 5, 2020

Conversation

stevematney
Copy link
Contributor

@stevematney stevematney commented Oct 5, 2020

Previously, we were loading all known javascript files for anything not specifically javascript. Now, we're only referencing the specific plugin files we intend to reference for syntax highlighting and indentation in styled-components. This should resolve any conflicts with other plugins.

after/indent/typescript.vim, after/indent/javascriptreact.vim,
and jsx.vim

* Not pulling in every indent/javascript.vim file.
* Resolves styled-components#75
* Resolves styled-components#76
@stevematney stevematney changed the title Limiting the scope of indent files. Limiting the scope of plugin files. Oct 5, 2020
@stevematney
Copy link
Contributor Author

Just to explain a bit on why this fix works: source allows us to read one specific file, which seems to be the intention of the previous runtime calls. The previous calls were doing much too broad of a search, and incidentally pulling in all the javascript syntax/indent/etc files from every plugin (including vim-styled-components) for all non-js filetypes (as described in the runtime help docs). This is why there were so many conflicts with other plugins.

@fleischie
Copy link
Collaborator

I unfortunately don't have the time/energy/...desire(?) to test this fully, so I suggest I merge this branch and let the potential issues flow in...

Also you are aware, that now with two merged PRs you are the most likely candidate to become the maintainer of this project? (Slightly joking, but not really. 😅 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants