Skip to content
This repository has been archived by the owner on Feb 9, 2023. It is now read-only.

At rule param case #41

Merged
merged 1 commit into from
Sep 15, 2020
Merged

At rule param case #41

merged 1 commit into from
Sep 15, 2020

Conversation

bartlangelaan
Copy link
Member

@bartlangelaan bartlangelaan commented Jul 19, 2020

Which issue, if any, is this issue related to?

Closes #38.

Original bug report:
stylelint/stylelint#4560

Is there anything in the PR that needs further explanation?

This makes sure that parameters of at-rules are untouched, and not converted from or to other casing styles.

All examples use 'glamorous' but it looks like, just as mentioned in the issue, the usage of camelCase is just wrong and should always be kebab-case. I have created a new test that makes sure that this works from now on, with a comment why this needs to be tested.

This merge request is dependent on #40 - which means, that merge request needs to be merged before this one.

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Feel free to merge after you merge #40 in.

@abdonrd
Copy link
Member

abdonrd commented Aug 31, 2020

Thanks @bartlangelaan!

@jeddy3
Copy link
Member

jeddy3 commented Sep 13, 2020

@bartlangelaan & @abdonrd I've given you both admin access to this repository.

You're welcome to merged pull requests as you see fit, as well as organise the repository, ci, release, etc however you like. In the stylelint organisation, we're trying to remove bottlenecks and barriers to getting contributions merged and released by better distributing permissions. I can also add you both to the stylelint npm organisation so that you can publish this package, just let me know in the private team discussion what email address to use.

Regardless of whether you accept the invitation or not, I wanted to say thank you for contributions to this package so far!

@abdonrd
Copy link
Member

abdonrd commented Sep 14, 2020

Thanks @jeddy3! I can try to help a bit in the repository, but I don't have much knowledge of how Stylelint works internally.

@jeddy3
Copy link
Member

jeddy3 commented Sep 14, 2020

I can try to help a bit in the repository,

Thank you!

I don't have much knowledge of how Stylelint works internally.

The original author of this package (and postcss-syntax, which you dipped into in stylelint/stylelint#4800 (comment)) is no longer active, so you probably know as much as anyone else!

@abdonrd
Copy link
Member

abdonrd commented Sep 15, 2020

@bartlangelaan can you rebase the PR please? Thanks!

@bartlangelaan bartlangelaan merged commit e37d564 into master Sep 15, 2020
@bartlangelaan bartlangelaan deleted the at-rule-param-case branch September 15, 2020 20:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Handling media query param case
3 participants