Update postcss-less to 1.0 #2702

jwilsson · 2017-07-01T11:20:14Z

Which issue, if any, is this issue related to?

Superseeds #2637.

Is there anything in the PR that needs further explanation?

This is still a WIP, two issues in no-extra-semicolons remains.

The big thing however, which isn't reflected by the tests are stringifying of the new Import node type in a couple of rules (string-quotes for example) and the use of node.positionBy() in utils/report. It would fail with the same TypeError: this[node.type] is not a function errors since the Root node there wasn't from postcss-less but from postcss. I found those issues while running stylelint via the CLI. However, I have a fix for that pending in shellscape/postcss-less#82. So as soon as that is merged and a new version is tagged there we should be good to go (after I've fixed no-extra-semicolons too of course).

The current changes I've made are just minor ones, passing the current syntax's stringifier to toResult when checking the file's newlines and updating isStandardSyntaxRule to use new property names for Less mixins/extends.

jeddy3 · 2017-07-01T16:07:03Z

@jwilsson It's fantastic to see this WIP! I'll label as review needed once the package.json is updated with that new version of postcss-less.

jwilsson · 2017-07-06T13:44:23Z

lib/rules/no-extra-semicolons/index.js

@@ -53,6 +53,10 @@ const rule = function (actual) {
    }

    root.walk(node => {
+      if (node.mixin) {


I'm not 100% satisfied with this current solution here and below, but we can't use isStandardSyntaxRule here since it checks for --custom-property-set: {}, thus failing other tests which uses that.

While working on this, though, I found myself thinking of a isLessRule util. Would that be of interest or is it too specific since it's a non-standard syntax thing? I was thinking that the isLessRule util would consist of the Less-specific checks from isStandardSyntaxRule and that isStandardSyntaxRule could make use of isLessRule instead.

Using a isLessRule here in no-extra-semicolons would also catch Less &:extend(.foo) rules which aren't currently ignored (&:extend(.foo) can of course be caught and ignored without it too, but a util would be a better fit IMO).

Would that be of interest or is it too specific since it's a non-standard syntax thing?

Too specific I'm afraid. Rules make use of the isStandardSyntax* utils to make sure only whitelisted constructs are dealt with within the rule. There are too many non-standard syntaxes to add special cases to individual rules, even if it's to explicitly ignore a piece of non-standard syntax. There are a lot of rules to maintain and having this consistent behaviour has benefited us thus far.

As such, I suggest we structure that conditional in terms of known construct and standard syntax utils i.e.:

if ( node.type === "rule" && !isCustomPropertySet(node) && !isStandardSyntaxRule(node) ) { return }

Gotcha! That's what I figured, but I thought I'd ask :)

jwilsson · 2017-07-06T13:46:14Z

lib/rules/no-extra-semicolons/__tests__/index.js

@@ -555,6 +555,6 @@ testRule(rule, {
    code: "a { .mixin();\ncolor: red;; }",
    message: messages.rejected,
    line: 2,
-    column: 10,
+    column: 11,


I actually believe that the old column here was incorrect, 11 makes more sense when checking it in my editor for example (the editor is reporting 11 as the first semicolon after red).

I'm happy to be proved wrong though!

jwilsson · 2017-07-06T13:47:21Z

All tests should pass as of the latest commit, just waiting for a new release of postcss-less.

jwilsson · 2017-07-10T12:37:10Z

lib/rules/no-extra-semicolons/__tests__/index.js

@@ -555,6 +555,6 @@ testRule(rule, {
    code: "a { .mixin();\ncolor: red;; }",
    message: messages.rejected,
    line: 2,
-    column: 10,
+    column: 12,


This should be even more correct, 12 corresponds to the last of the two semicolons.

jwilsson · 2017-07-10T12:38:28Z

This should be ready for review. The new postcss-less version is out and in package.json.

jeddy3

@jwilsson Big thanks again for picking up this Less update and putting in the legwork.

I've made two requests to tweak how the conditionals in the no-extra-semicolon rule are structured. Other than that, this looks great!

Would you like me to add you to the stylelint org? That way any future Less-related updates you might do can happen on a branch here.

jeddy3 · 2017-07-10T20:12:46Z

lib/rules/no-extra-semicolons/index.js

@@ -53,6 +53,10 @@ const rule = function (actual) {
    }

    root.walk(node => {
+      if (node.mixin) {


Would that be of interest or is it too specific since it's a non-standard syntax thing?

Too specific I'm afraid. Rules make use of the isStandardSyntax* utils to make sure only whitelisted constructs are dealt with within the rule. There are too many non-standard syntaxes to add special cases to individual rules, even if it's to explicitly ignore a piece of non-standard syntax. There are a lot of rules to maintain and having this consistent behaviour has benefited us thus far.

As such, I suggest we structure that conditional in terms of known construct and standard syntax utils i.e.:

if ( node.type === "rule" && !isCustomPropertySet(node) && !isStandardSyntaxRule(node) ) { return }

jeddy3 · 2017-07-10T20:15:15Z

lib/rules/no-extra-semicolons/index.js

@@ -87,6 +91,15 @@ const rule = function (actual) {
      const rawAfterNode = node.raws.after

      if (rawAfterNode && rawAfterNode.trim().length !== 0) {
+        /**


As above, let's check if the last node is a standard rule or a custom property set:

if ( node.last && node.last.type === "rule" && !isCustomPropertySet(node.last) && !isStandardSyntaxRule(node.last) ) { return }

jwilsson · 2017-07-11T06:16:41Z

Would you like me to add you to the stylelint org? That way any future Less-related updates you might do can happen on a branch here.

Sure, happy to help out!

…-semicolons

jeddy3

Thanks for making the changes.

LGTM.

I've restarted the node 8.x tests... it's been temperamental.

I've added you to the org. Welcome onboard :)

ntwb · 2017-07-11T06:52:34Z

Welcome @jwilsson 😄

jeddy3 · 2017-07-11T06:57:30Z

Tests are now green. LGTM.

* Add stylelint semantic versioning policy * Fix whitespace and empty lines * Add changelog entry * Remove stylelint-config=standard reference * Tweak major release optional options verbiage * Update changelog * Props ESLint * Fix false negatives with ignore: ["descendant"] in selector-no-type (#2200) * Update CHANGELOG.md * Fix handling of shared-line comments (#2262) * Fix handling of shared-line comments Introduces a number of utilities and adjusts the following rules: at-rule-empty-line-before, custom-property-empty-line-before, declaration-empty-line-before, rule-nested-empty-line-before, rule-non-nested-empty-line-before Closes #2237; closes #2239; closes #2240. * Fixes based on feedback * Use getPreviousNonSharedLineCommentNode more * Use more new helpers in comment-empty-line-before * Add ignore: ["child"] option to selector-no-type (#2217) * Add ignore: ["child"] option to selector-no-type * Correct logic for ignore: ["child"] option * Include line and column in reject tests with multiple type selectors * Update CHANGELOG.md * Report every selector resolved selector in selector-max-compound-selectors (#2350) * Update CHANGELOG.md * Add new shorthand data (#2354) * Add new shorthand data * Add mask shorthand * Use defined list of properties in shorthand-property-no-redundant-values * Improve declaration-block-no-shorthand-property-overrides speed a little bit * Check prefixed properties agains prefixed properties in declaration-block-no-shorthand-property-overrides * Improve declaration-block-no-redundant-longhand-properties speed a little bit * Ignore prefixes case in declaration-block-no-shorthand-property-overrides * Check prefixed properties agains prefixed properties in declaration-block-no-redundant-longhand-properties * Add `grid-gap` to shorthand-property-no-redundant-values * Explain properties set for shorthand-property-no-redundant-values * Revert unnecessary changes * Add “mask” to declaration-block-no-redundant-longhand-properties readme * Update CHANGELOG.md * Update changelog * Remove deprecated rules (#2422) * Remove deprecated rules * Include `rule-empty-line-before` in system tests * *-empty-line-before rules consider line as empty if it contains whitespace only (#2440) * Update CHANGELOG.md * Remove deprecated options (#2433) * Update CHANGELOG.md * report-needless-disables now exits with non-zero code (#2341) * Update CHANGELOG.md * Remove leftover files (#2442) * Remove leftover file * One more * And one more * Ignoring improvements (#2464) * WIP ignoring improvements * Remove standaloneIgnored property of result * Add disableDefaultIgnores * Add documentation tweaks * Add parseStylelintIgnore tests * Non-absolutized ignore file paths * Restire gitignore syntax * Remove parseStylelintIgnore * Update CHANGELOG.md * Check all linear-gradients in a value list (#2496) Closes #2481 * Update CHANGELOG.md * Update CHANGELOG.md * Respect line case for `ignorePattern` (#2683) Closes #2647 * Update CHANGELOG.md * Update decls * Fix remark warning * Update snapshots * Add missing message to reject test * Fix tests for *-empty-line-before rules (#2688) * Fix tests for *-empty-line-before rules * Test addition and tweak * Update to PostCSS@6 (#2561) * Update to PostCSS@6 * Fix PostCSS@6 closing-brace test (#2689) * Account for PostCSS@6's support for at-apply * Remove only * Fix postcssPlugin tests (#2690) * Fix defaultSeverity.test.js test * Fix ignoreDisables test * Check ownSemiColon * Fixed: remove hacks related to custom property set. * Remove deprecated rules (#2693) Closes #2521 * Update CHANGELOG.md * Update CHANGELOG.md * Add VISION.md (#2704) * Add releases.md (#2705) * Add releases.md Closes #2700 * Add dry-release step * Use HTTPS for links * Change ignore options for selector-max-type (#2701) * Fix false negatives with ignore descendant * Add ignore child Closes #2699 * Update CHANGELOG.md * Update README.md to account for VISION.md (#2727) * Update README.md to account for VISION.md * Fix lint warnings in CHANGELOG * Update postcss-less to 1.0 (#2702) * Update postcss-less to 1.0.2 * Update isStandardSyntaxRule for postcss-less 1.0 * Pass custom postcss stringifier when creating result * Correct no-extra-semicolons Less test position * Ignore Less mixins in no-extra-semicolons * Update postcss-less to 1.1.0 * Correct no-extra-semicolons Less test position again * Utilize isStandardSyntaxRule when checking for Less rules in no-extra-semicolons * Case sensitive white/blacklists and ignore* options (#2709) Closes #2660 * Update CHANGELOG.md * docs: Add "New Release Issue Template" to releases.md (#2728) * Exit with non-zero code on postcss warnings (#2713) * Enhancement: exit with non zero code on postcss warnings. * Account for parseErrors in stringformatqer * Guard against no parseErrors * Update CHANGELOG.md * Refactor: simplify ignore logic. (#2732) * Update changelog * Bump 8.0.0 changes to top * Correctly place changelog items * Add introduction * Add codefence for website * Use relative path * Include VISION in package for website * Add link to VISION doc for website * Changelog amends * Update releases.md (#2738) * Update eslint and config (#2737) * Order requires * Use eqeqeq eslint rule * Update eslint * Disable no-useless-escape just for this repo * Enable no-useless-escape rule * Use tilde * Fix enable comment * Add reject test for unescaped regex

jwilsson added 3 commits July 1, 2017 12:33

Update postcss-less to 1.0.2

fe16c74

Update isStandardSyntaxRule for postcss-less 1.0

db7eeb9

Pass custom postcss stringifier when creating result

9f5d6b3

jeddy3 mentioned this pull request Jul 1, 2017

Update postcss-less to the latest version 🚀 #2637

Closed

jeddy3 added the PR: needs revision label Jul 1, 2017

jeddy3 mentioned this pull request Jul 6, 2017

Add support for disableFix to built-in rules #2708

Closed

jwilsson added 2 commits July 6, 2017 15:39

Correct no-extra-semicolons Less test position

64b5b11

Ignore Less mixins in no-extra-semicolons

72c9d4a

jwilsson commented Jul 6, 2017

View reviewed changes

jwilsson added 2 commits July 10, 2017 14:34

Update postcss-less to 1.1.0

28aac0d

Correct no-extra-semicolons Less test position again

76c8136

jwilsson commented Jul 10, 2017

View reviewed changes

jwilsson changed the title ~~[WIP] Update postcss-less to 1.0~~ Update postcss-less to 1.0 Jul 10, 2017

alexander-akait added PR: review needed and removed PR: needs revision labels Jul 10, 2017

alexander-akait mentioned this pull request Jul 10, 2017

Update postcss-less to the latest version 🚀 #2726

Closed

jeddy3 requested changes Jul 10, 2017

View reviewed changes

jeddy3 mentioned this pull request Jul 10, 2017

Release 8.0.0 #2575

Closed

6 tasks

Utilize isStandardSyntaxRule when checking for Less rules in no-extra…

f42cf59

…-semicolons

jeddy3 approved these changes Jul 11, 2017

View reviewed changes

alexander-akait approved these changes Jul 11, 2017

View reviewed changes

jeddy3 added PR: review accepted and removed PR: review needed labels Jul 11, 2017

jeddy3 merged commit b99eabe into stylelint:v8 Jul 11, 2017

Arcanemagus mentioned this pull request Jul 13, 2017

Strange LESS file message AtomLinter/linter-stylelint#181

Closed

ntwb mentioned this pull request Jul 14, 2017

remove LESS support experimental disclaimer #2739

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update postcss-less to 1.0 #2702

Update postcss-less to 1.0 #2702

jwilsson commented Jul 1, 2017 •

edited

Loading

jeddy3 commented Jul 1, 2017

jwilsson Jul 6, 2017

jeddy3 Jul 10, 2017 •

edited

Loading

jwilsson Jul 11, 2017

jwilsson Jul 6, 2017 •

edited

Loading

jwilsson commented Jul 6, 2017

jwilsson Jul 10, 2017

jwilsson commented Jul 10, 2017

jeddy3 left a comment

jeddy3 Jul 10, 2017 •

edited

Loading

jeddy3 Jul 10, 2017 •

edited

Loading

jwilsson commented Jul 11, 2017

jeddy3 left a comment •

edited

Loading

ntwb commented Jul 11, 2017

jeddy3 commented Jul 11, 2017

Update postcss-less to 1.0 #2702

Update postcss-less to 1.0 #2702

Conversation

jwilsson commented Jul 1, 2017 • edited Loading

jeddy3 commented Jul 1, 2017

jwilsson Jul 6, 2017

Choose a reason for hiding this comment

jeddy3 Jul 10, 2017 • edited Loading

Choose a reason for hiding this comment

jwilsson Jul 11, 2017

Choose a reason for hiding this comment

jwilsson Jul 6, 2017 • edited Loading

Choose a reason for hiding this comment

jwilsson commented Jul 6, 2017

jwilsson Jul 10, 2017

Choose a reason for hiding this comment

jwilsson commented Jul 10, 2017

jeddy3 left a comment

Choose a reason for hiding this comment

jeddy3 Jul 10, 2017 • edited Loading

Choose a reason for hiding this comment

jeddy3 Jul 10, 2017 • edited Loading

Choose a reason for hiding this comment

jwilsson commented Jul 11, 2017

jeddy3 left a comment • edited Loading

Choose a reason for hiding this comment

ntwb commented Jul 11, 2017

jeddy3 commented Jul 11, 2017

jwilsson commented Jul 1, 2017 •

edited

Loading

jeddy3 Jul 10, 2017 •

edited

Loading

jwilsson Jul 6, 2017 •

edited

Loading

jeddy3 Jul 10, 2017 •

edited

Loading

jeddy3 Jul 10, 2017 •

edited

Loading

jeddy3 left a comment •

edited

Loading