Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support logical combinations #4179

Merged
merged 3 commits into from
Jul 31, 2019
Merged

support logical combinations #4179

merged 3 commits into from
Jul 31, 2019

Conversation

vankop
Copy link
Member

@vankop vankop commented Jul 29, 2019

Which issue, if any, is this issue related to?

closes #2657

Is there anything in the PR that needs further explanation?

nothing

alexander-akait
alexander-akait reviewed Jul 29, 2019
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can we add test with nested with multiple body:not(div):not(span) {} ?

@vankop
Copy link
Member Author

vankop commented Jul 29, 2019

Looks good, can we add test with nested with multiple body:not(div):not(span) {} ?

which rule? or every selector-pseudo-class-* ?

@alexander-akait
Copy link
Member

Any, just ensure this case also covered

@vankop
Copy link
Member Author

vankop commented Jul 29, 2019

Looks good, can we add test with nested with multiple body:not(div):not(span) {} ?

done

hudochenkov
hudochenkov approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hudochenkov hudochenkov merged commit b658f41 into stylelint:master Jul 31, 2019
@hudochenkov
Copy link
Member

  • Added: selector-* support for all logical combinations (:matches, :has) (#4179).

@vankop vankop deleted the support-logical-combinations branch July 31, 2019 09:34
@jeddy3
Copy link
Member

jeddy3 commented Jul 31, 2019

@vankop It's great to see some old issues being addressed! Thank you for your work on all your recent pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

@hudochenkov hudochenkov hudochenkov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for all logical combinations (:matches, :has) in selector-*
4 participants
@vankop @alexander-akait @hudochenkov @jeddy3