Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PostCSS plugin ignoring .stylelintignore #4186

Merged
merged 4 commits into from
Sep 4, 2019

Conversation

joe223
Copy link
Member

@joe223 joe223 commented Aug 4, 2019

Which issue, if any, is this issue related to?

Closes #4134.

Is there anything in the PR that needs further explanation?

Relative documentation https://github.com/joe223/stylelint/blob/master/docs/user-guide/postcss-plugin.md#ignorepath.

Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution breaks tests. Please, change your solution.

.gitignore Outdated Show resolved Hide resolved
@joe223
Copy link
Member Author

joe223 commented Aug 7, 2019

@hudochenkov Unit test all passed.

Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you, please, add tests to postcssPlugin.test.js. You could take a look at ignore.test.js for examples using CLI and adopt them to PostCSS plugin API.

@joe223
Copy link
Member Author

joe223 commented Aug 18, 2019

ASAP.
I have checked the

describe("standalone with .stylelintignore file ignoring one file", () => {
.

This unit tests cover all standalone's ignore configuration. I guess PostCSS plugin API ignorePath configuration unit test should be almost.

@joe223
Copy link
Member Author

joe223 commented Aug 31, 2019

@hudochenkov I have add one unit test for postcssPlugin ignorePath option, this option works with .stylelintignore file to ignore style files.

I was too busy recently.🙁

@hudochenkov
Copy link
Member

Thank you!

@hudochenkov hudochenkov merged commit 162dfcf into stylelint:master Sep 4, 2019
@hudochenkov
Copy link
Member

  • Fixed: PostCSS plugin ignoring .stylelintignore (#4186).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix PostCSS plugin ignoring .stylelintignore
3 participants