Add minimum node version to engine field in package.json #4790
Conversation
There was a problem hiding this comment.
@rgranger Thanks! I've requested a change.
You'll also need to run npm run format to resolve the lint warning.
As an aside, once we roll out stylelint/npm-package-json-lint-config across the stylelint repositories they'll all have engine fields as the config requires it.
README.md
Outdated
| @@ -19,6 +19,8 @@ It's mighty as it: | |||
| - is **unopinionated** so that you can customize it to your exact needs | |||
| - has a **growing community** and is used by [Facebook](https://code.facebook.com/posts/879890885467584/improving-css-quality-at-facebook-and-beyond/), [GitHub](https://github.com/primer/stylelint-config-primer) and [WordPress](https://github.com/ntwb/stylelint-config-wordpress/) | |||
|
|
|||
| Minimum NodeJs version supported : v10.13.0 | |||
There was a problem hiding this comment.
We can remove this line as using the engine field in the package.json will suffice. It's the standardised way of communicating a package's compatibility and will produce a warning on the CLI when npm i is used, e.g.:
npm WARN notsup Unsupported engine for stylelint@13.4.0: wanted: {"node":">=10.13.0"} (current: {"node":"8.17.0","npm":"6.13.4"})
There was a problem hiding this comment.
Ok, line has been removed from the readme
|
@rgranger Thanks for making the change. You'll need to run It'll likely reorder the engine property in the |
jeddy3
changed the title
|
done |
|
Changelog:
|
#4787
e.g. "No, it's self-explanatory."