Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ignoreFunctions: [] to length-zero-no-unit #5314

Merged
merged 3 commits into from
May 19, 2021
Merged

Add ignoreFunctions: [] to length-zero-no-unit #5314

merged 3 commits into from
May 19, 2021

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented May 18, 2021

Which issue, if any, is this issue related to?

Closes #5082
Closes #4945

Is there anything in the PR that needs further explanation?

Implements what I wrote in #5082 (comment)

mattxwang
mattxwang approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A short and sweet change, LGTM!

ybiquitous
ybiquitous approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some comments, but this change looks good. 👍🏼

lib/rules/length-zero-no-unit/README.md Outdated Show resolved Hide resolved
lib/rules/length-zero-no-unit/__tests__/index.js Show resolved Hide resolved
jeddy3 and others added 2 commits May 19, 2021 13:19
@jeddy3 @ybiquitous
Update lib/rules/length-zero-no-unit/README.md
25dccb0 
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@jeddy3 @ybiquitous
Update lib/rules/length-zero-no-unit/__tests__/index.js
dbc7a33 
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@jeddy3 jeddy3 merged commit 492ae33 into v14 May 19, 2021
@jeddy3 jeddy3 deleted the issue-4945 branch May 19, 2021 12:40
@jeddy3
Copy link
Member Author

jeddy3 commented May 19, 2021

  • Added: ignoreFunctions: [] to length-zero-no-unit (#5314).

@sync-by-unito sync-by-unito bot mentioned this pull request Nov 1, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Dec 1, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jan 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

@mattxwang mattxwang mattxwang approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeddy3 @ybiquitous @mattxwang