Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix end positions for number-max-precision #6184

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Fix end positions for number-max-precision #6184

merged 1 commit into from
Jun 29, 2022

Conversation

mattxwang
Copy link
Member

Which issue, if any, is this issue related to?

Part of #5694.

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

ybiquitous
ybiquitous approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattxwang Thanks, LGTM 👍🏼

jeddy3
jeddy3 approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jeddy3 jeddy3 merged commit 0e8a9a0 into main Jun 29, 2022
@jeddy3 jeddy3 deleted the end-positions-number-max-precision branch June 29, 2022 10:07
@jeddy3
Copy link
Member

jeddy3 commented Jun 29, 2022

  • Fixed: number-max-precision end positions (#6184).

@sync-by-unito sync-by-unito bot mentioned this pull request Sep 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

@ybiquitous ybiquitous ybiquitous approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattxwang @jeddy3 @ybiquitous