Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix declaration-block-no-redundant-longhand-properties end positions #6219

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Part of #5694

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

@@ -93,6 +93,7 @@ const rule = (primary, secondaryOptions) => {
ruleName,
result,
node: decl,
word: decl.prop,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[note] If not specify word, endColumn would point to the end of the declaration's value. However, I think it's too long. So this change indicates just a property name.

Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just highlighting the property for the first redundant longhand property makes sense. LGTM!

@ybiquitous ybiquitous merged commit 6f01dfb into main Jul 28, 2022
@ybiquitous ybiquitous deleted the declaration-block-no-redundant-longhand-properties-end-positions branch July 28, 2022 08:47
@ybiquitous
Copy link
Member Author

Changelog entry added:

  • Fixed: declaration-block-no-redundant-longhand-properties end positions (#6219).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants