Fix *-no-redundant-* false negatives for inset shorthand
#6699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 95e24f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rayrw
changed the title
declaration-block-no-redundant-longhand-properties false negatives for inset shorthandinset property shorthand
ybiquitous
requested changes
Mar 8, 2023
There was a problem hiding this comment.
@rayrw Thanks for the pull request. Almost LGTM, but I've left several comments about the code style. Could you please consider addressing them?
lib/rules/declaration-block-no-redundant-longhand-properties/__tests__/index.js
Outdated
Show resolved
Hide resolved
lib/rules/declaration-block-no-redundant-longhand-properties/__tests__/index.js
Outdated
Show resolved
Hide resolved
|
@ybiquitous Thanks for the reviews! |
ybiquitous
changed the title
inset property shorthanddeclaration-block-no-redundant-longhand-properties and shorthand-property-no-redundant-values false negatives for inset shorthand
ybiquitous
approved these changes
Mar 8, 2023
jeddy3
reviewed
Mar 8, 2023
jeddy3
changed the title
declaration-block-no-redundant-longhand-properties and shorthand-property-no-redundant-values false negatives for inset shorthand*-no-redundant-* false negatives for inset shorthand
ybiquitous
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
@jeddy3 Thanks for making the title and changelog much simpler! 👍🏼
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6613
This PR updates these 2 rules to support the
insetpropertydeclaration-block-no-redundant-longhand-propertiesshorthand-property-no-redundant-values