Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selector-id-pattern performance #7013

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Fix selector-id-pattern performance #7013

merged 2 commits into from
Jun 30, 2023

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Jun 30, 2023

Which issue, if any, is this issue related to?

Ref #6869

Is there anything in the PR that needs further explanation?

Mean: 240.67508675000005 ms
Deviation: 20.382065001610304 ms

To

Mean: 85.73348046666666 ms
Deviation: 8.678100769643914 ms

Avoiding unnecessary selector parsing is a win. We seldom see id selectors in the wild.

@changeset-bot
Copy link

changeset-bot bot commented Jun 30, 2023

🦋 Changeset detected

Latest commit: 65dc8bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement with a few characters! 🎉

@jeddy3 jeddy3 merged commit 3ec4821 into main Jun 30, 2023
@jeddy3 jeddy3 deleted the fix-sip-p branch June 30, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants