[WIP] Fix symmetry plane issues in SU2, change SU2-NEMO sym plane to match flow solver #1635

jtneedels · 2022-05-13T20:52:42Z

Proposed Changes

This PR will help address issues seen in SU2 when symmetry planes are applied. These include pressure oscillations at sym plane & solid wall interfaces (i.e. blunt bodies). It will also change the implementation of the sym plane in SU2-NEMO to that used by the rest of the code, the template function in CFVMFlowSolverBase.inl.

Related Work

This PR will largely utilize the work done in #1168 by Fabio Morgado. It is in addition to #657. It will address several open issues #1625 and #1125.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

I am submitting my contribution to the develop branch.
My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
My contribution is commented and consistent with SU2 style.
I have added a test case that demonstrates my contribution, if necessary.
I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

Signed-off-by: jtneedels <jneedels@stanford.edu>

jtneedels · 2022-05-13T21:51:51Z

SU2_CFD/include/variables/CIncEulerVariable.hpp

@@ -269,5 +269,19 @@ class CIncEulerVariable : public CFlowVariable {
  inline void SetVelSolutionVector(unsigned long iPoint, const su2double *val_vector) final {
    for (unsigned long iDim = 0; iDim < nDim; iDim++) Solution(iPoint, iDim+1) = val_vector[iDim];
  }
+ /*!


Is there a better way to do this rather an than adding dummy functions to these variable classes? The compiler throws an error since NEMO requires these 3 functions, which don't exist in the other solvers. Would it be better to pass the variable type into the sym plane template explicitly somehow, like what is done for conv_numerics?

The variable type is known in CFVMFlowSolverBase, but to do something conditionally on a type in C++11 you need to create a helper function that is specialized for the type (CNEMOEulerVariable in this case)

template <class VariableType> void SetExtraVars(unsigned long, VariableType*, CNumerics*) { // Do nothing for non-NEMO solvers. } template <> void SetExtraVars<CNEMOEulerVariable>(unsigned long iPoint, CNEMOEulerVariable* nodes, CNumerics* numerics) { // Template specialization for NEMO variables, here you set Eve, etc. ... }

@pcarruscag Do both the general template function declaration and the specialized declaration go in the inl file (i.e. implemented as you have it above? I get a compilation error of "unknown type name 'CNEMOEulerVariable'; did you mean 'CEulerVariable'?".

Try putting the specialization in CNEMOEulerSolver.h

SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

pcarruscag · 2022-05-13T22:48:57Z

SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

+      if (nemo) {
+        conv_numerics->SetEve   (nodes->GetEve(iPoint),    nodes->GetEve(iPoint));
+        conv_numerics->SetCvve  (nodes->GetCvve(iPoint),   nodes->GetCvve(iPoint));
+        conv_numerics->SetGamma (nodes->GetGamma(iPoint),  nodes->GetGamma(iPoint));


Do not use pretty formatting, we have a clang-format style

Suggested change

if (nemo) {

conv_numerics->SetEve (nodes->GetEve(iPoint), nodes->GetEve(iPoint));

conv_numerics->SetCvve (nodes->GetCvve(iPoint), nodes->GetCvve(iPoint));

conv_numerics->SetGamma (nodes->GetGamma(iPoint), nodes->GetGamma(iPoint));

if (nemo) {

conv_numerics->SetEve(nodes->GetEve(iPoint), nodes->GetEve(iPoint));

conv_numerics->SetCvve(nodes->GetCvve(iPoint), nodes->GetCvve(iPoint));

conv_numerics->SetGamma(nodes->GetGamma(iPoint), nodes->GetGamma(iPoint));

pcarruscag · 2022-05-13T22:59:06Z

SU2_CFD/include/variables/CIncEulerVariable.hpp

@@ -269,5 +269,19 @@ class CIncEulerVariable : public CFlowVariable {
  inline void SetVelSolutionVector(unsigned long iPoint, const su2double *val_vector) final {
    for (unsigned long iDim = 0; iDim < nDim; iDim++) Solution(iPoint, iDim+1) = val_vector[iDim];
  }
+ /*!


The variable type is known in CFVMFlowSolverBase, but to do something conditionally on a type in C++11 you need to create a helper function that is specialized for the type (CNEMOEulerVariable in this case)

template <class VariableType> void SetExtraVars(unsigned long, VariableType*, CNumerics*) { // Do nothing for non-NEMO solvers. } template <> void SetExtraVars<CNEMOEulerVariable>(unsigned long iPoint, CNEMOEulerVariable* nodes, CNumerics* numerics) { // Template specialization for NEMO variables, here you set Eve, etc. ... }

Signed-off-by: jtneedels <jneedels@stanford.edu>

WallyMaier · 2022-05-25T04:56:09Z

SU2_CFD/src/variables/CNEMOEulerVariable.cpp

@@ -90,6 +90,9 @@ CNEMOEulerVariable::CNEMOEulerVariable(su2double val_pressure,
  eves.resize(nPoint, nSpecies)  = su2double(0.0);
  Gamma.resize(nPoint)           = su2double(0.0);

+  /* Vector to count number of symmetry planes at each node. */
+  symmetry.resize(nPoint) = su2double(0.0);


This will be needed for the base and Inc solvers too, correct?

SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

jtneedels · 2022-05-31T06:46:26Z

SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

-          V_reflected[iDim + 1] = nodes->GetVelocity(iPoint, iDim) - 2.0 * ProjVelocity_i * UnitNormal[iDim];        
-      }  
+      for (iDim = 0; iDim < nDim; iDim++)
+        V_reflected[prim_idx.Velocity() + iDim] = nodes->GetVelocity(iPoint, iDim) - 2.0 * ProjVelocity_i * UnitNormal[iDim];


I tried this and it gave an error when running with nemo, which is why I didn't push it. Did you test and ensured this gave correct results?

On my machine, it didn't seem to have any issues. What issues did you see?

The test case solution I was using gave the wrong solution when I used this.

Strange, I just double checked (after I fixed my compilation errors I caused). The value of the velocity index was 7 for AIR-5.

Signed-off-by: jtneedels <jneedels@stanford.edu>

bigfooted · 2022-07-18T08:43:51Z

hi guys, what's the status of this WIP? By the way, does this also show changes (improvements I hope) in convergence, or is that not affected by the change

jtneedels · 2022-07-19T04:57:47Z

Hi @bigfooted, I'm a bit perplexed because even with using the same sym plane BC in CFVMFlowSolverBase.inl as the standard air solver, the NEMO solver continues to have issues (pressure defects at stagnation point on sym boundary wall). The last working push in Fabio's original PR seem to fix these problems, but they involve some pretty significant changes to the code (complete change of BC, change of order of applications of BCs in CIntegration, etc.). I'm a bit stuck since I'm not sure why all these changes are necessary to get good results for NEMO, when the current implementation seems to work in CFVMFlowSolverBase.inl for the standard air solver. I was hoping to chat about this at the next developer meeting.

stale · 2022-09-21T00:55:40Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions.

SU2_CFD/include/solvers/CFVMFlowSolverBase.inl


  /*--- Allocation of variables necessary for convective fluxes. ---*/
  su2double Area, ProjVelocity_i, *V_reflected, *V_domain, Normal[MAXNDIM] = {0.0}, UnitNormal[MAXNDIM] = {0.0};

  /*--- Allocation of variables necessary for viscous fluxes. ---*/
  su2double ProjGradient, ProjNormVelGrad, ProjTangVelGrad, TangentialNorm,
-      Tangential[MAXNDIM] = {0.0}, GradNormVel[MAXNDIM] = {0.0}, GradTangVel[MAXNDIM] = {0.0};
+      Tangential[MAXNDIM] = {0.0}, GradNormVel[MAXNDIM] = {0.0}, GradTangVel[MAXNDIM] = {0.0}, Residual[MAXNVAR] = {0.0};


stale · 2023-05-21T21:02:42Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions.

pcarruscag

Nijso's fix to the symmetry is in so I'm closing this PR.
I'll delete the branch next week unless someone wants to keep it.

jtneedels added 2 commits May 13, 2022 13:47

init commit -- switch bc_sym plane in NEMO to CFVMFlowSolverBase.inl

0c9d78b

Signed-off-by: jtneedels <jneedels@stanford.edu>

init commit -- switch bc_sym plane in NEMO to CFVMFlowSolverBase.inl

2b53647

Signed-off-by: jtneedels <jneedels@stanford.edu>

pr-triage bot added the PR: draft label May 13, 2022

jtneedels added 2 commits May 13, 2022 14:39

add virtual variable functions

f4e97f8

Signed-off-by: jtneedels <jneedels@stanford.edu>

remove unneeded functions from CNEMOEulerSolver.cpp/.hpp

885e646

Signed-off-by: jtneedels <jneedels@stanford.edu>

jtneedels commented May 13, 2022

View reviewed changes

pcarruscag changed the title ~~Fix symmetry plane issues in SU2, change SU2-NEMO sym plane to match flow solver~~ [WIP] Fix symmetry plane issues in SU2, change SU2-NEMO sym plane to match flow solver May 13, 2022

pcarruscag reviewed May 13, 2022

View reviewed changes

SU2_CFD/include/solvers/CFVMFlowSolverBase.inl Outdated Show resolved Hide resolved

pcarruscag reviewed May 13, 2022

View reviewed changes

jtneedels added 3 commits May 13, 2022 16:52

initial attempt at adding normal correction

996519d

Signed-off-by: jtneedels <jneedels@stanford.edu>

formatting

f6cc1fc

Signed-off-by: jtneedels <jneedels@stanford.edu>

working for 2d and 3d cases NEMO EULER, needs cleanup

521d92a

Signed-off-by: jtneedels <jneedels@stanford.edu>

WallyMaier mentioned this pull request May 19, 2022

Fix incompressible velocity inlet on intersections with viscous walls #1631

Merged

5 tasks

WallyMaier added 2 commits May 18, 2022 22:34

Merge branch 'develop' into feature_sym_plane

36005c7

Merge branch 'develop' into feature_sym_plane

7a16116

WallyMaier reviewed May 25, 2022

View reviewed changes

SU2_CFD/include/solvers/CFVMFlowSolverBase.inl Outdated Show resolved Hide resolved

WallyMaier reviewed May 25, 2022

View reviewed changes

SU2_CFD/include/solvers/CFVMFlowSolverBase.inl Outdated Show resolved Hide resolved

jtneedels and others added 3 commits May 26, 2022 21:45

Merge branch 'develop' into feature_sym_plane

045c541

Merge branch 'develop' into feature_sym_plane

d59a2df

Apply suggestions from code review

a96cec1

jtneedels commented May 31, 2022

View reviewed changes

WallyMaier and others added 4 commits May 31, 2022 08:29

address compile issues

8749ffc

fix more compilation issues

44fda97

xcode

d5aa1cc

Signed-off-by: jtneedels <jneedels@stanford.edu>

Merge branch 'develop' into feature_sym_plane

719b2d3

jtneedels closed this Jul 19, 2022

jtneedels reopened this Jul 19, 2022

stale bot added the stale label Sep 21, 2022

Merge branch 'develop' into feature_sym_plane

f1407d7

stale bot removed the stale label Oct 19, 2022

Merge branch 'develop' into feature_sym_plane

7e91fb0

github-advanced-security bot found potential problems Dec 13, 2022

View reviewed changes

stale bot added the stale label May 21, 2023

pcarruscag reviewed Aug 11, 2024

View reviewed changes

stale bot removed the stale label Aug 11, 2024

pcarruscag closed this Aug 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Fix symmetry plane issues in SU2, change SU2-NEMO sym plane to match flow solver #1635

[WIP] Fix symmetry plane issues in SU2, change SU2-NEMO sym plane to match flow solver #1635

jtneedels commented May 13, 2022

jtneedels May 13, 2022

pcarruscag May 13, 2022 •

edited

Loading

jtneedels Jun 4, 2022

pcarruscag Jun 4, 2022

pcarruscag May 13, 2022

pcarruscag May 13, 2022 •

edited

Loading

WallyMaier May 25, 2022

jtneedels May 31, 2022

WallyMaier May 31, 2022

jtneedels May 31, 2022

WallyMaier May 31, 2022

bigfooted commented Jul 18, 2022

jtneedels commented Jul 19, 2022

stale bot commented Sep 21, 2022

stale bot commented May 21, 2023

pcarruscag left a comment

[WIP] Fix symmetry plane issues in SU2, change SU2-NEMO sym plane to match flow solver #1635

[WIP] Fix symmetry plane issues in SU2, change SU2-NEMO sym plane to match flow solver #1635

Conversation

jtneedels commented May 13, 2022

Proposed Changes

Related Work

PR Checklist

Choose a reason for hiding this comment

pcarruscag May 13, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pcarruscag May 13, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bigfooted commented Jul 18, 2022

jtneedels commented Jul 19, 2022

stale bot commented Sep 21, 2022

stale bot commented May 21, 2023

pcarruscag left a comment

Choose a reason for hiding this comment

pcarruscag May 13, 2022 •

edited

Loading

pcarruscag May 13, 2022 •

edited

Loading