Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CST parameterization method #2124

Merged
merged 11 commits into from
Sep 23, 2023
Merged

Fix CST parameterization method #2124

merged 11 commits into from
Sep 23, 2023

Conversation

Zcaic
Copy link
Contributor

@Zcaic Zcaic commented Sep 1, 2023

Related Work

  1. I add some code about CST to CSurfaceMovement.cpp and it can work well.

  2. I add a test case named "cst" in TestCases/deformation. It contains test case for CST mesh deformation.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@pcarruscag pcarruscag changed the base branch from master to develop September 1, 2023 22:51
@pcarruscag pcarruscag changed the title add cst to CSurfaceMovement.cpp Fix CST parameterization method Sep 1, 2023
Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, add yourself to AUTHORS.md please, since you added it as a testcase, we can try to make a regression test.
Can you check if your config works with the mesh I'm suggesting below (it's in the TestCases repo)? Then you need to change parallel_regression.py (look for /deformation/ to find the other tests).

TestCases/deformation/cst/naca0012.cfg Outdated Show resolved Hide resolved
@Zcaic
Copy link
Contributor Author

Zcaic commented Sep 2, 2023

@pcarruscag ,
I have modified the cfg file and it passed the test with mpirun -n 2 SU2_DEF naca0012.cfg.
I also modified AUTHORS.md and parallel_regression.py

TestCases/parallel_regression.py Outdated Show resolved Hide resolved
TestCases/parallel_regression.py Outdated Show resolved Hide resolved
TestCases/deformation/cst/Mesh Deformation Comparison.png Outdated Show resolved Hide resolved
Common/src/grid_movement/CSurfaceMovement.cpp Outdated Show resolved Hide resolved
AUTHORS.md Outdated Show resolved Hide resolved
@Zcaic
Copy link
Contributor Author

Zcaic commented Sep 2, 2023

Sorry, some was caused by my carelessness,. I've modified it.

@pcarruscag pcarruscag merged commit 26656da into su2code:develop Sep 23, 2023
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants