Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aachen testcase #2367

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Fix aachen testcase #2367

wants to merge 7 commits into from

Conversation

alecappiello
Copy link
Contributor

Proposed Changes

I discovered that the Aachen regression test was actually on its way to divergence. I think this explains why the regression test was behaving inconsistently, although I'm not sure about what caused this problem.

I made a new mesh, introduced wall functions as suggested by @joshkellyjak, and switched to second order directly.
The convergence history is good. See the attached convergence histories obtained with JST starting from scratch with outlet pressure ramp.
conv_hist_rotor1
conv_hist_stator1
conv_hist_stator2

I have finally updated the restart files accordingly.

Related Work

I think these small changes could fix the issues encountered in the past with this test case.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@joshkellyjak joshkellyjak changed the base branch from master to develop October 17, 2024 14:11
@joshkellyjak joshkellyjak changed the title Fix aachen testcase [WIP] Fix aachen testcase Oct 17, 2024
@joshkellyjak joshkellyjak changed the title [WIP] Fix aachen testcase Fix aachen testcase Oct 18, 2024
@joshkellyjak joshkellyjak marked this pull request as ready for review October 18, 2024 08:49
@joshkellyjak
Copy link
Contributor

@pcarruscag I think we may have spoken about this before but my memory does not serve me well, do you have any idea as to why the residual values change when we remove the entropy fix coeff?

@pcarruscag
Copy link
Member

hmm maybe boundaries, we still use the Roe scheme on boundaries even with JST, I stand corrected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants