Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update plugin for Pyright 1.1.98 #48

Merged
merged 3 commits into from
Jan 4, 2021
Merged

refactor: update plugin for Pyright 1.1.98 #48

merged 3 commits into from
Jan 4, 2021

Conversation

jfcherng
Copy link
Collaborator

@jfcherng jfcherng commented Jan 2, 2021

Resolves #47

@jfcherng
chore: update sublime-package.json for Pyright 1.1.98
7bccc4c 
From https://github.com/microsoft/pyright/blob/1.1.98/packages/vscode-pyright/package.json

Signed-off-by: Jack Cherng <jfcherng@gmail.com>
@jfcherng
refactor: Pyright uses LSP-native progress reporting
2bda6b5 
So reported messages should be dealt in LSP.

Signed-off-by: Jack Cherng <jfcherng@gmail.com>
@jfcherng jfcherng changed the title chore: update sublime-package.json for Pyright 1.1.98 Update plugin for Pyright 1.1.98 Jan 2, 2021
@jfcherng jfcherng changed the title Update plugin for Pyright 1.1.98 refactor: update plugin for Pyright 1.1.98 Jan 2, 2021
@jfcherng jfcherng requested a review from rchl January 2, 2021 06:33
rchl
rchl requested changes Jan 2, 2021
View reviewed changes
Copy link
Member

@rchl rchl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Also remove self._activity_indicator from plugin.py (or whole init` in fact).
  • update LSP-pyright.sublime-settings with new options

sublime-package.json Outdated Show resolved Hide resolved
@jfcherng
fixup!
dd789f8 
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
@rchl
Copy link
Member

rchl commented Jan 3, 2021

Can you also add new options to sublime-settings file?

@jfcherng
Copy link
Collaborator Author

jfcherng commented Jan 4, 2021 •
edited
Loading

Can you also add new options to sublime-settings file?

I am afraid that I don't know what you are exactly referring to. If you mean those diagnostic rules, there are LOTS of them which are not listed in the sublime-settings file.

rchl
rchl approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@rchl rchl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, OK, I thought we are listing them all.

@jfcherng jfcherng merged commit 41b3c9f into master Jan 4, 2021
@jfcherng jfcherng deleted the chore/fit-pyright-1.1.98 branch January 4, 2021 10:45
@jfcherng jfcherng added the enhancement New feature or request label Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchl rchl rchl approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup plugin after updating pyright dep
2 participants
@jfcherng @rchl